-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support proxy routing via gRPC default_authority #1202
feat: support proxy routing via gRPC default_authority #1202
Conversation
f27db24
to
0497bd8
Compare
Signed-off-by: raflFaisal <[email protected]>
0497bd8
to
cfc030f
Compare
Signed-off-by: raflFaisal <[email protected]>
I'm OK with this solution, but it's distinctly different from the solution in other providers as you noted here:
While I'm OK with this solution, the title of this PR (which is what will show up in the release notes) doesn't seem accurate. It can address a subset of the same problems of a custom name resolver, but unless I'm very confused, it's not a custom name resolver. |
@toddbaert You are correct, let me change the PR title that matches with the code change. "feat: support proxy routing via gRPC default_authority" Let me know if it looks good to you |
Yep, that sounds good to me. Just make sure to update any readme or inline docs as well to say the same sort of thing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with one minor nit here: https://github.com/open-feature/js-sdk-contrib/pull/1202/files#r1945277742
Looks really good overall. Thanks for the good README and explanations!
I'll merge and release tomorrow. Please consider Todd's comment but I don't think it's a blocker. |
This PR
To provide a :authority header to request route to target backend services using default_authority parameter by the JS clients. This enable better integration with service proxies like Envoy, facilitating more flexible and robust gRPC client configurations.
Related Issues
#1187
open-feature/flagd#1532
How to test
Use defaultAuthority parameter to pass down the target authority when sending a grpc request from client side.