add long value support

Signed-off-by: Kavindu Dodanduwa <[email protected]>
open-feature · Jun 7, 2023 · e78fed7 · e78fed7
1 parent 7e54a26
commit e78fed7
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 0 deletions.
diff --git a/src/main/java/dev/openfeature/sdk/FlagMetadata.java b/src/main/java/dev/openfeature/sdk/FlagMetadata.java
@@ -37,6 +37,16 @@ public Integer getInteger(final String key) {
         return getValue(key, Integer.class);
     }
 
+    /**
+     * Retrieve a {@link Long} value for the given key. A {@code null} value is returned if the key does not exist
+     * or if the value is of a different type.
+     *
+     * @param key flag metadata key to retrieve
+     */
+    public Long getLong(final String key) {
+        return getValue(key, Long.class);
+    }
+
     /**
      * Retrieve a {@link Float} value for the given key. A {@code null} value is returned if the key does not exist
      * or if the value is of a different type.
@@ -123,6 +133,17 @@ public FlagMetadataBuilder addInteger(final String key, final Integer value) {
             return this;
         }
 
+        /**
+         * Add Long value to the metadata.
+         *
+         * @param key   flag metadata key to add
+         * @param value flag metadata value to add
+         */
+        public FlagMetadataBuilder addLong(final String key, final Long value) {
+            metadata.put(key, value);
+            return this;
+        }
+
         /**
          * Add Float value to the metadata.
          *

diff --git a/src/test/java/dev/openfeature/sdk/FlagMetadataTest.java b/src/test/java/dev/openfeature/sdk/FlagMetadataTest.java
@@ -14,6 +14,7 @@ public void builder_validation() {
         FlagMetadata flagMetadata = FlagMetadata.builder()
                 .addString("string", "string")
                 .addInteger("integer", 1)
+                .addLong("long", 1L)
                 .addFloat("float", 1.5f)
                 .addDouble("double", Double.MAX_VALUE)
                 .addBoolean("boolean", Boolean.FALSE)
@@ -22,6 +23,7 @@ public void builder_validation() {
         // then
         assertThat(flagMetadata.getString("string")).isEqualTo("string");
         assertThat(flagMetadata.getInteger("integer")).isEqualTo(1);
+        assertThat(flagMetadata.getLong("long")).isEqualTo(1L);
         assertThat(flagMetadata.getFloat("float")).isEqualTo(1.5f);
         assertThat(flagMetadata.getDouble("double")).isEqualTo(Double.MAX_VALUE);
         assertThat(flagMetadata.getBoolean("boolean")).isEqualTo(Boolean.FALSE);