Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix broken test caused by change in OkHhttp MockWebServer default behaviour #735

Conversation

matthewelwell
Copy link
Member

This PR

Fixes broken test in the existing renovate PR caused by a (suspected) change in the OkHttp MockWebServer class's default behaviour.

This PR explicitly updates the mock error server to respond with a 500 error for all requests.

Related Issues

N/a

Notes

N/a

Follow-up Tasks

N/a

How to test

mvn test

@matthewelwell matthewelwell requested a review from a team as a code owner April 3, 2024 11:25
@github-actions github-actions bot requested a review from ajhelsby April 3, 2024 11:25
@matthewelwell matthewelwell force-pushed the renovate/com.flagsmith-flagsmith-java-client-7.x branch from a6fa2ec to ddb0d8e Compare April 3, 2024 11:26
@matthewelwell matthewelwell changed the title Fix broken test caused by change in OkHhttp MockWebServer default behaviour test: fix broken test caused by change in OkHhttp MockWebServer default behaviour Apr 3, 2024
@beeme1mr beeme1mr merged commit bb738ff into open-feature:renovate/com.flagsmith-flagsmith-java-client-7.x Apr 3, 2024
3 of 4 checks passed
@matthewelwell matthewelwell deleted the renovate/com.flagsmith-flagsmith-java-client-7.x branch April 3, 2024 15:22
DBlanchard88 pushed a commit to DBlanchard88/java-sdk-contrib that referenced this pull request Apr 29, 2024
…ure#735)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants