feat!: use new eval/sync protos (requires flagd v0.7.3+) #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
beeme1mr,
Kavindu-Dodan and
thisthat
toddbaert
force-pushed
the
feat/new-proto-and-e2e-tests
branch
2 times, most recently
from
92c9300 to
bd39f99
Compare
toddbaert
commented
Feb 15, 2024
...src/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/model/FlagParser.java
Show resolved
Hide resolved
toddbaert
commented
Feb 15, 2024
...rc/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/storage/FlagStore.java
Outdated
Show resolved
Hide resolved
toddbaert
commented
Feb 15, 2024
...d/src/test/java/dev/openfeature/contrib/providers/flagd/e2e/reconnect/rpc/FlagdRpcSetup.java
Show resolved
Hide resolved
toddbaert
commented
Feb 15, 2024
toddbaert
commented
Feb 15, 2024
toddbaert
commented
Feb 15, 2024
...s/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/e2e/steps/StepDefinitions.java
Show resolved
Hide resolved
toddbaert
commented
Feb 15, 2024
...c/test/java/dev/openfeature/contrib/providers/flagd/e2e/reconnect/steps/StepDefinitions.java
Show resolved
Hide resolved
toddbaert
commented
Feb 15, 2024
...src/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/model/FlagParser.java
Show resolved
Hide resolved
...src/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/model/FlagParser.java
Outdated
Show resolved
Hide resolved
providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/common/Util.java
Show resolved
Hide resolved
thisthat
reviewed
Feb 19, 2024
...rc/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/storage/FlagStore.java
Outdated
Show resolved
Hide resolved
...src/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/model/FlagParser.java
Show resolved
Hide resolved
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
…s/flagd/resolver/process/model/FlagParser.java Co-authored-by: Kavindu Dodanduwa <[email protected]> Signed-off-by: Todd Baert <[email protected]>
Co-authored-by: Giovanni Liva <[email protected]> Signed-off-by: Todd Baert <[email protected]>
…s/flagd/resolver/process/storage/FlagStore.java Co-authored-by: Giovanni Liva <[email protected]> Signed-off-by: Todd Baert <[email protected]>
toddbaert
force-pushed
the
feat/new-proto-and-e2e-tests
branch
from
ffc5bde to
230a0b1
Compare
Signed-off-by: Todd Baert <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made one functional change here which only WARNS instead of throwing if the flag config is invalid. Happy to go either way on this.