feat: synchronize initialization and shutdown #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kavindu-Dodan
changed the title
Kavindu-Dodan
force-pushed
the
feat/flagd-concurrency-improvements
branch
from
dd0f4be to
61a8ad7
Compare
toddbaert
reviewed
Jan 16, 2024
providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/FlagdProvider.java
Outdated
Show resolved
Hide resolved
beeme1mr
approved these changes
Jan 16, 2024
Kavindu-Dodan
force-pushed
the
feat/flagd-concurrency-improvements
branch
from
61a8ad7 to
118b7f8
Compare
Signed-off-by: Kavindu Dodanduwa <[email protected]>
Kavindu-Dodan
force-pushed
the
feat/flagd-concurrency-improvements
branch
from
118b7f8 to
e4b32d2
Compare
markphelps
added a commit
to flipt-io/java-sdk-contrib
that referenced
this pull request
Jan 17, 2024
…java-sdk-contrib into upgrade-flipt-provider * 'upgrade-flipt-provider' of https://github.com/flipt-io/java-sdk-contrib: feat: synchronize initialization and shutdown (open-feature#635)
markphelps
pushed a commit
to flipt-io/java-sdk-contrib
that referenced
this pull request
Jan 19, 2024
Signed-off-by: Kavindu Dodanduwa <[email protected]> Signed-off-by: Mark Phelps <[email protected]>
markphelps
added a commit
to flipt-io/java-sdk-contrib
that referenced
this pull request
Jan 19, 2024
…java-sdk-contrib into upgrade-flipt-provider * 'upgrade-flipt-provider' of https://github.com/flipt-io/java-sdk-contrib: chore: try to fix flipt provider tests chore: try to rename somethings chore(deps): update actions/cache action to v4 (open-feature#639) chore: try to fix flipt provider test chore: try to fix flipt provider test feat: synchronize initialization and shutdown (open-feature#635) refactor(flipt): upgrade Flipt provider to use latest 1.0.0 Flipt SDK fix(deps): update dependency io.netty:netty-transport-native-epoll to v4.1.105.final (open-feature#634)
DBlanchard88
pushed a commit
to DBlanchard88/java-sdk-contrib
that referenced
this pull request
Apr 29, 2024
…ure#635) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Fixes #623 by adding synchronization on init & shutdown along with initialize state variable to avoid multiple initializations and shutdowns