Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow flagd-provider cache to be disabled #201

Merged
merged 2 commits into from
Jan 17, 2023

Conversation

skyerus
Copy link
Contributor

@skyerus skyerus commented Jan 17, 2023

This PR

Fixes issue when using flagd-provider with cache disabled.

Related Issues

Notes

Follow-up Tasks

How to test

@toddbaert
Copy link
Member

I think it would be a good idea to add one test case for this. That's my general rule for discovering any sort of bug - it means a test was probably missing!

@skyerus
Copy link
Contributor Author

skyerus commented Jan 17, 2023

It was discovered while working on the integration tests, it's covered there now but I think you're right that it should be covered by a unit test too

@skyerus skyerus force-pushed the fix/caching-disabled branch from ee0800e to df0c049 Compare January 17, 2023 16:36
@toddbaert toddbaert merged commit f505b83 into open-feature:main Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants