feat: flagd-provider ssl, socket, deadline, env support #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddbaert
requested review from
justinabrahms,
beeme1mr,
Kavindu-Dodan,
skyerus and
james-milligan
toddbaert
force-pushed
the
feat/flagd-enhancements
branch
from
75fc729 to
1762196
Compare
Signed-off-by: Todd Baert <[email protected]>
toddbaert
force-pushed
the
feat/flagd-enhancements
branch
from
1762196 to
022d8c4
Compare
toddbaert
commented
Nov 21, 2022
| final String host = "server.com"; | ||
| final int port = 4321; | ||
|
|
||
| new EnvironmentVariables("FLAGD_HOST", host, "FLAGD_PORT", String.valueOf(port)).execute(() -> { |
There was a problem hiding this comment.
This is a pretty cool library for mocking env vars, might be interesting to you @justinabrahms
skyerus
approved these changes
Nov 22, 2022
beeme1mr
approved these changes
Nov 22, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds to flagd-java:
There's also some formatting / spacing changes to bring things in line with the Java SDK.
Closes: #129
EDIT: Interestingly there's a certificate validation issue with this version (the latest) of
netty-handler. I'll see what I can do about this but it's not looking great.https://security.snyk.io/vuln/SNYK-JAVA-IONETTY-1042268
I've added a comment about this to the readme. For our purposes, I think we can live with this vuln for now. The netty authors have addressed it in netty 5, but that's still alpha.