feat: protobuf-java@4 compatibility #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddbaert
force-pushed
the
feat/protobuf-4-compat
branch
from
bae8a60 to
d0be844
Compare
aepfli
approved these changes
Jan 2, 2025
|
are the submodules updates needed? |
toddbaert
force-pushed
the
feat/protobuf-4-compat
branch
from
d0be844 to
cb7b176
Compare
nope, sorry, will correct. |
toddbaert
force-pushed
the
feat/protobuf-4-compat
branch
from
cb7b176 to
60544a2
Compare
Signed-off-by: Todd Baert <[email protected]>
toddbaert
force-pushed
the
feat/protobuf-4-compat
branch
from
60544a2 to
1089dd0
Compare
beeme1mr
approved these changes
Jan 2, 2025
This was referenced Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to new protoc version which removes problematic calls (namely
makeExtensionsImmutable), giving compatibility with protobuf-java v4 (tested manually).Compatibility with protobuf-java@3 remains.