fix: int/float auto-conversion #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: DBlanchard88 <[email protected]>
github-actions
bot
requested review from
beeme1mr,
Kavindu-Dodan and
toddbaert
Signed-off-by: DBlanchard88 <[email protected]>
Signed-off-by: DBlanchard88 <[email protected]>
toddbaert
reviewed
Oct 7, 2023
...s/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/e2e/steps/StepDefinitions.java
Show resolved
Hide resolved
toddbaert
reviewed
Oct 7, 2023
...est/java/dev/openfeature/contrib/providers/flagd/resolver/process/InProcessResolverTest.java
Show resolved
Hide resolved
toddbaert
reviewed
Oct 7, 2023
...rc/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/InProcessResolver.java
Outdated
Show resolved
Hide resolved
toddbaert
approved these changes
Oct 7, 2023
There was a problem hiding this comment.
Thanks for the fix and the testing @DBlanchard88 . Approved, but I will wait to see if @Kavindu-Dodan has a more elegant approach for this. If not, I will merge.
...rc/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/InProcessResolver.java
Outdated
Show resolved
Hide resolved
Kavindu-Dodan
approved these changes
Oct 9, 2023
Sure I'll wait a bit for @DBlanchard88 to check out your suggestion. |
…s/flagd/resolver/process/InProcessResolver.java Co-authored-by: Kavindu Dodanduwa <[email protected]> Signed-off-by: David Blanchard <[email protected]>
toddbaert
changed the title
DBlanchard88
pushed a commit
to DBlanchard88/java-sdk-contrib
that referenced
this pull request
Apr 29, 2024
…ure#472) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #470