-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flagd/in-process] float flags with 0.0 value are parsed as ints #470
Comments
I summarised my findings here - https://github.com/open-feature/java-sdk-contrib/pull/468/files#r1344520202 IMO this can be safely fixed at the in-process provider end. A special handling for Double should fix this |
I was thinking this too... in fact, to be consistent with RPC, I think we have to attempt conversion in both directions, int -> float and float -> int (RPC does this). Additionally, if we do this, we may need to specify how the float -> int conversion is done... I think Java and Go both round toward zero... I believe .NET does too. This might be worth specifying. I will proceed with a fix as described above unless @Kavindu-Dodan or @beeme1mr disagrees. |
Yes, I agree that we should cast the values. This should be documented in the spec. |
I think i understand how to do this. Ill take a shot at it. |
Alright, cool. Assigned. |
…pen-feature#470) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
The flagd in-process provider should be able to resolve ints as floats, and vice-versa.
To fix:
Background:
Originally posted by @toddbaert in #468 (comment)
The text was updated successfully, but these errors were encountered: