Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Restore integration test stability #425

Closed
skyerus opened this issue Feb 22, 2023 · 1 comment · Fixed by open-feature/go-sdk-contrib#123 or #432
Closed

[FEATURE] Restore integration test stability #425

skyerus opened this issue Feb 22, 2023 · 1 comment · Fixed by open-feature/go-sdk-contrib#123 or #432
Assignees
Labels
enhancement New feature or request

Comments

@skyerus
Copy link
Contributor

skyerus commented Feb 22, 2023

Requirements

Changes to flagd's sync mechanisms have caused the integration tests to become unstable. Investigate & eliminate points of instability.

@skyerus skyerus added enhancement New feature or request Needs Triage This issue needs to be investigated by a maintainer labels Feb 22, 2023
@skyerus skyerus self-assigned this Feb 22, 2023
@skyerus skyerus removed the Needs Triage This issue needs to be investigated by a maintainer label Feb 22, 2023
@skyerus
Copy link
Contributor Author

skyerus commented Feb 22, 2023

The problem is that the tests replace the contents of the flag configuration file with the amended configuration (to test that cache has been invalidated). In doing this, flagd receives the change event, pulls the contents of the file, sees that the file is empty (it hasn't been written to yet), interprets this as an empty state and invalidates all of the cache. Then the configuration gets written to the file and flagd interprets the event correctly.

Potential solutions:

@skyerus skyerus reopened this Feb 24, 2023
skyerus added a commit that referenced this issue Feb 24, 2023
<!-- Please use this template for your pull request. -->
<!-- Please use the sections that you need and delete other sections -->

## This PR
<!-- add the description of the PR here -->

- Absorbs test module changes (using symbolic links for integration
tests)

### Related Issues
<!-- add here the GitHub issue that this PR resolves if applicable -->

Fixes #425 

### Notes
<!-- any additional notes for this PR -->

### Follow-up Tasks
<!-- anything that is related to this PR but not done here should be
noted under this section -->
<!-- if there is a need for a new issue, please link it here -->

### How to test
<!-- if applicable, add testing instructions under this section -->

---------

Signed-off-by: Skye Gill <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment