-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Restore integration test stability #425
[FEATURE] Restore integration test stability #425
Comments
The problem is that the tests replace the contents of the flag configuration file with the amended configuration (to test that cache has been invalidated). In doing this, flagd receives the change event, pulls the contents of the file, sees that the file is empty (it hasn't been written to yet), interprets this as an empty state and invalidates all of the cache. Then the configuration gets written to the file and flagd interprets the event correctly. Potential solutions:
|
<!-- Please use this template for your pull request. --> <!-- Please use the sections that you need and delete other sections --> ## This PR <!-- add the description of the PR here --> - Absorbs test module changes (using symbolic links for integration tests) ### Related Issues <!-- add here the GitHub issue that this PR resolves if applicable --> Fixes #425 ### Notes <!-- any additional notes for this PR --> ### Follow-up Tasks <!-- anything that is related to this PR but not done here should be noted under this section --> <!-- if there is a need for a new issue, please link it here --> ### How to test <!-- if applicable, add testing instructions under this section --> --------- Signed-off-by: Skye Gill <[email protected]>
Requirements
Changes to flagd's sync mechanisms have caused the integration tests to become unstable. Investigate & eliminate points of instability.
The text was updated successfully, but these errors were encountered: