Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate security findings #321

Closed
toddbaert opened this issue Jan 25, 2023 · 1 comment · Fixed by #464
Closed

Investigate security findings #321

toddbaert opened this issue Jan 25, 2023 · 1 comment · Fixed by #464
Assignees
Labels

Comments

@toddbaert
Copy link
Member

Scans from a potential adoptor resulted in some findings. We should investigate these:

pkg/sync/http_sync.go
    go.lang.security.audit.crypto.bad_imports.insecure-module-used
       Detected use of an insecure cryptographic hashing method. This method is known to be broken
       and easily compromised. Use SHA256 or SHA3 instead.
       Details: https://sg.run/l2gj
 
        69hasher := sha1.New() //nolint:gosec
         ⋮┆----------------------------------------
    go.lang.security.audit.crypto.use_of_weak_crypto.use-of-sha1
       Detected SHA1 hash algorithm which is considered insecure. SHA1 is not collision resistant
       and is therefore not suitable as a cryptographic signature. Use SHA256 or SHA3 instead.
       Details: https://sg.run/XBYA
 
        69hasher := sha1.New() //nolint:gosec
pkg/sync/kubernetes/kubernetes_sync.go
     trailofbits.go.questionable-assignment.questionable-assignment
        Should `k` be modified when an error could be returned?
        Details: https://sg.run/qq6y
 
        117k.client, err = client.New(clusterConfig, client.Options{Scheme: scheme.Scheme})
@odubajDT
Copy link
Contributor

odubajDT commented Mar 3, 2023

Hey, I would like to take this issue :)

beeme1mr pushed a commit that referenced this issue Mar 6, 2023
## This PR

- fixes security findings

### Related Issues

Fixes #321

---------

Signed-off-by: odubajDT <[email protected]>
Co-authored-by: Todd Baert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants