Image #401
Merged
Image #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Publishing the image should be part of the release process; so we should also ensure the Make target is called during the GitHub Actions workflow used for release. |
morri-son
approved these changes
Jul 11, 2023
mandelsoft
reviewed
Jul 11, 2023
| GITHUBORG ?= open-component-model | ||
| COMPONENT = $(PROVIDER)/$(NAME) | ||
| OCMREPO ?= ghcr.io/$(GITHUBORG)/ocm | ||
| PLATFORMS = linux/amd64 linux/arm64 darwin/arm64 darwin/amd64 windows/amd64 | ||
| MULTI ?= true | ||
| CONTAINER_PLATFORMS ?= linux/amd64 linux/arm64 |
There was a problem hiding this comment.
Hmm, I think you mean IMAGE_PLATFORMS
robertwol
pushed a commit
that referenced
this pull request
Sep 25, 2023
* generate ocmcli-image * docker cli build: add sources, remove platforms * Update Makefile with correct platform for image build --------- Co-authored-by: Uwe Krueger <[email protected]> Co-authored-by: Gerald Morrison <[email protected]>
hilmarf
pushed a commit
that referenced
this pull request
Jan 31, 2025
See [#401 - Automatically set milestone at issues when closed](open-component-model/ocm-project#401) for more information. Co-authored-by: ocmbot[bot] <125909804+ocmbot[bot]@users.noreply.github.com>
hilmarf
pushed a commit
that referenced
this pull request
Feb 7, 2025
See [#401 - Automatically set milestone at issues when closed](open-component-model/ocm-project#401) for more information. Now with reuse of central managed action. Co-authored-by: ocmbot[bot] <125909804+ocmbot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Added dockerfile and build scripts to create a docker image with the OCM CLI
Which issue(s) this PR fixes:
Fixes #289
Special notes for your reviewer:
Release Notes: