Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: ✨ support cel selector #693

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

haoqing0110
Copy link
Member

Summary

Related issue(s)

Fixes #

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 76.59574% with 11 lines in your changes missing coverage. Please review.

Project coverage is 63.80%. Comparing base (037aa3c) to head (ebeae14).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/placement/plugins/predicate/predicate.go 23.07% 8 Missing and 2 partials ⚠️
pkg/placement/helpers/testing/builders.go 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #693      +/-   ##
==========================================
+ Coverage   63.78%   63.80%   +0.02%     
==========================================
  Files         192      192              
  Lines       18606    18633      +27     
==========================================
+ Hits        11868    11889      +21     
- Misses       5759     5764       +5     
- Partials      979      980       +1     
Flag Coverage Δ
unit 63.80% <76.59%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metav1.LabelSelector `json:",inline"`

// +optional
RegexSelector map[string]string `json:"regexSelector,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would consider a CEL based selector, which could be more flexible.
e.g. could reference a score value

Copy link
Contributor

openshift-ci bot commented Dec 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: haoqing0110
Once this PR has been reviewed and has the lgtm label, please assign qiujian16 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@haoqing0110 haoqing0110 changed the title WIP: support regex selector WIP: support cel selector Dec 13, 2024
@haoqing0110 haoqing0110 force-pushed the br_regex branch 3 times, most recently from 41396ee to fc97656 Compare December 23, 2024 09:06
Signed-off-by: Qing Hao <[email protected]>
@haoqing0110 haoqing0110 changed the title WIP: support cel selector WIP: ✨ support cel selector Jan 6, 2025
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants