Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Send available condition events for managed cluster #450

Conversation

zhujian7
Copy link
Member

Summary

Related issue(s)

Fixes #

@openshift-ci openshift-ci bot requested review from elgnay and skeeey April 30, 2024 03:00
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 59.52381% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 62.58%. Comparing base (5fc1dbd) to head (557bf0c).

Files Patch % Lines
...stration/spoke/managedcluster/status_controller.go 69.56% 4 Missing and 3 partials ⚠️
pkg/registration/hub/lease/controller.go 42.85% 4 Missing ⚠️
pkg/registration/spoke/spokeagent.go 0.00% 4 Missing ⚠️
pkg/common/helpers/event_recorder.go 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #450   +/-   ##
=======================================
  Coverage   62.57%   62.58%           
=======================================
  Files         135      136    +1     
  Lines       11472    11504   +32     
=======================================
+ Hits         7179     7200   +21     
- Misses       3528     3536    +8     
- Partials      765      768    +3     
Flag Coverage Δ
unit 62.58% <59.52%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhujian7 zhujian7 force-pushed the cluster-available-event branch 2 times, most recently from 0cdb036 to 7ed15d6 Compare April 30, 2024 06:36
@zhujian7
Copy link
Member Author

/assign @qiujian16 @elgnay

pkg/registration/hub/lease/controller.go Outdated Show resolved Hide resolved
pkg/registration/spoke/managedcluster/status_controller.go Outdated Show resolved Hide resolved
pkg/registration/spoke/spokeagent.go Outdated Show resolved Hide resolved
@zhujian7 zhujian7 force-pushed the cluster-available-event branch from 7ed15d6 to bec338d Compare May 6, 2024 03:53
@zhujian7 zhujian7 force-pushed the cluster-available-event branch from bec338d to 557bf0c Compare May 6, 2024 04:00
@qiujian16
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 6, 2024
Copy link
Contributor

openshift-ci bot commented May 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label May 6, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit c749b42 into open-cluster-management-io:main May 6, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants