Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 update placement integration testing code with patcher #217

Conversation

haoqing0110
Copy link
Member

Summary

Replace placement integration testing code Update(), UpdateStatus() with PatchSpec and PatchStatus().

Related issue(s)

Fixes #

@openshift-ci openshift-ci bot requested review from elgnay and xuezhaojun July 12, 2023 06:10
@haoqing0110 haoqing0110 changed the title 🌱 update placement integration testing 🌱 update placement integration testing code with patcher Jul 12, 2023
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5db2240) 60.26% compared to head (a227fdf) 60.26%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #217   +/-   ##
=======================================
  Coverage   60.26%   60.26%           
=======================================
  Files         128      128           
  Lines       13411    13411           
=======================================
  Hits         8082     8082           
  Misses       4584     4584           
  Partials      745      745           
Flag Coverage Δ
unit 60.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@haoqing0110
Copy link
Member Author

/assign @qiujian16

@qiujian16
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 12, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haoqing0110, qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 320098e into open-cluster-management-io:main Jul 12, 2023
@haoqing0110 haoqing0110 deleted the br_placement-test branch July 12, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants