Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Being able to match multiple items in jsonpath #202

Conversation

qiujian16
Copy link
Member

Summary

This allows a jsonpatch to match multiple items and returns a list with jsonraw

Related issue(s)

Fixes #
open-cluster-management-io/work#196

This allows a jsonpatch to match multiple items and
returns a list with jsonraw

Signed-off-by: Jian Qiu <[email protected]>
@openshift-ci openshift-ci bot requested review from elgnay and haoqing0110 June 29, 2023 03:33
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Patch coverage: 84.61% and project coverage change: +0.01 🎉

Comparison is base (e4792e4) 59.66% compared to head (d7dcdd9) 59.68%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #202      +/-   ##
==========================================
+ Coverage   59.66%   59.68%   +0.01%     
==========================================
  Files         127      127              
  Lines       13239    13250      +11     
==========================================
+ Hits         7899     7908       +9     
- Misses       4600     4602       +2     
  Partials      740      740              
Flag Coverage Δ
unit 59.68% <84.61%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/work/spoke/statusfeedback/reader.go 72.17% <84.61%> (+1.02%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

elgnay pushed a commit to elgnay/ocm that referenced this pull request Jun 29, 2023
@zhujian7
Copy link
Member

zhujian7 commented Jul 4, 2023

LGTM

@elgnay
Copy link
Contributor

elgnay commented Jul 5, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 5, 2023
@openshift-merge-robot openshift-merge-robot merged commit 8c92c70 into open-cluster-management-io:main Jul 5, 2023
@qiujian16 qiujian16 deleted the jsonpath-multimatch branch September 6, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants