🐛 make the clusteradm join output more clear #444
Conversation
|
/assign @qiujian16 |
| - apiGroups: |
There was a problem hiding this comment.
I do no think agent needs this clusterrole?
There was a problem hiding this comment.
the auto approval feature is controlled by the clustermanager, when we use clusteradm join a cluster, we need read the clustermanager to see it if enable the auto approval feature, so I added this clusterrole for bootstrap token
There was a problem hiding this comment.
But it is mainly for clusteradm to know, not agent, right?
There was a problem hiding this comment.
right, it is mainly for clusteradm to know
There was a problem hiding this comment.
for clusteradm join, it seems we only have the bootstrap token, right?
There was a problem hiding this comment.
or we give a clear messages instead of checking the auto approval feature? e.g.
Your managed cluster cluster1 has joined the Hub.
If the ManagedClusterAutoApproval feature is not enabled, Please log onto the hub ...
There was a problem hiding this comment.
yes, I think this would be better.
skeeey
force-pushed
the
msg
branch
2 times, most recently
from
9bcaec8 to
c6c32a9
Compare
skeeey
changed the title
pkg/cmd/join/exec.go
Outdated
| @@ -355,7 +355,8 @@ func (o *Options) run() error { | |||
| } | |||
| } | |||
|
|
|||
| fmt.Fprintf(o.Streams.Out, "Please log onto the hub cluster and run the following command:\n\n"+ | |||
| fmt.Fprintf(o.Streams.Out, "\nYour managed cluster %s has joined the Hub.\n", o.values.ClusterName) | |||
There was a problem hiding this comment.
since ManagedClusterAutoApproval is disable by default, we might say
Please log onto the hub cluster and run the following command: at first and then say it is not needed when If the ManagedClusterAutoApproval feature is not enabled.
Signed-off-by: Wei Liu <[email protected]>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, skeeey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 50f18d1
into
open-cluster-management-io:main
Summary
Related issue(s)
Fixes #372