update cma config reference #163
Conversation
haoqing0110
force-pushed
the
br_update-cma-status
branch
3 times, most recently
from
b19eba6 to
71c618b
Compare
haoqing0110
force-pushed
the
br_update-cma-status
branch
from
71c618b to
618b77e
Compare
haoqing0110
force-pushed
the
br_update-cma-status
branch
from
618b77e to
5e78d6c
Compare
haoqing0110
force-pushed
the
br_update-cma-status
branch
2 times, most recently
from
9016b79 to
822dcab
Compare
Signed-off-by: haoqing0110 <[email protected]>
pkg/addonmanager/controllers/managementaddonconfig/controller.go
Outdated
Show resolved
Hide resolved
pkg/addonmanager/controllers/managementaddonconfig/controller.go
Outdated
Show resolved
Hide resolved
|
|
||
| func getInstallConfigIndex(config addonapiv1alpha1.InstallConfigReference) string { | ||
| if config.DesiredConfig.Namespace != "" { | ||
| return fmt.Sprintf("%s/%s/%s/%s", config.Group, config.Resource, config.DesiredConfig.Namespace, config.DesiredConfig.Name) |
There was a problem hiding this comment.
i think the index for empty namespace could "foo/bar//name". This is still unique for each one, right?
There was a problem hiding this comment.
yes, still unique for each one, to check if namespace is empty or not is to make it easy to use cache.DeletionHandlingMetaNamespaceKeyFunc(obj) to get above namespace/name or name I think.
There was a problem hiding this comment.
to may understanding DeletionHandlingMetaNamespaceKeyFunc can also handle /name as name, the returned namespace is just empty
pkg/addonmanager/controllers/managementaddonconfig/controller.go
Outdated
Show resolved
Hide resolved
pkg/addonmanager/controllers/managementaddonconfig/controller.go
Outdated
Show resolved
Hide resolved
pkg/addonmanager/controllers/managementaddonconfig/controller.go
Outdated
Show resolved
Hide resolved
haoqing0110
force-pushed
the
br_update-cma-status
branch
2 times, most recently
from
37d1110 to
49073aa
Compare
| @@ -171,13 +172,20 @@ func (a *addonManager) Start(ctx context.Context) error { | |||
| ) | |||
|
|
|||
| var addonConfigController factory.Controller | |||
| var managementAddonConfigController factory.Controller | |||
| if len(a.addonConfigs) != 0 { | |||
| addonConfigController = addonconfig.NewAddonConfigController( | |||
There was a problem hiding this comment.
do we still need to keep this controller if addon manager is enabled?
There was a problem hiding this comment.
yes, the addonConfigController is responsible to update spec hash for mca.spec.configs when addon manager is enabled.
pkg/addonmanager/controllers/managementaddonconfig/controller.go
Outdated
Show resolved
Hide resolved
pkg/addonmanager/controllers/managementaddonconfig/controller.go
Outdated
Show resolved
Hide resolved
pkg/addonmanager/controllers/managementaddonconfig/controller.go
Outdated
Show resolved
Hide resolved
pkg/addonmanager/controllers/managementaddonconfig/controller.go
Outdated
Show resolved
Hide resolved
pkg/addonmanager/controllers/managementaddonconfig/controller.go
Outdated
Show resolved
Hide resolved
Signed-off-by: haoqing0110 <[email protected]>
haoqing0110
force-pushed
the
br_update-cma-status
branch
from
49073aa to
2c060bc
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haoqing0110, qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
this PR is to update the config reference in cma status, it is part of the implementation of rollout strategy
Ref: open-cluster-management-io/ocm#114