add config-spec-hash annotation to manifestwork #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @qiujian16 @zhiweiyin318 |
qiujian16
reviewed
Mar 17, 2023
| } | ||
| resourceStr := v.Resource | ||
| if len(v.Group) > 0 { | ||
| resourceStr += fmt.Sprintf(".%s", v.Group) |
There was a problem hiding this comment.
the function needs a doc on what annotation will be generated.
There was a problem hiding this comment.
add some comments for this function.
haoqing0110
force-pushed
the
br_config-annotations
branch
from
cca7df9 to
30da3c7
Compare
haoqing0110
force-pushed
the
br_config-annotations
branch
2 times, most recently
from
17491a2 to
c0c8f4f
Compare
Signed-off-by: haoqing0110 <[email protected]>
haoqing0110
force-pushed
the
br_config-annotations
branch
from
c0c8f4f to
ebd5d5c
Compare
haoqing0110
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haoqing0110, qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: open-cluster-management-io/ocm#114