Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed stdout when lines are cleared #70

Merged
merged 1 commit into from
Jul 10, 2017

Conversation

aecz
Copy link
Contributor

@aecz aecz commented Nov 17, 2016

Some ANSI code are not well processed like those that clear the entire line or move the cursor around.
Still need to support moving the cursor to far left as its conflicting with the coloredPrefix.
https://en.wikipedia.org/wiki/ANSI_escape_code

Some ANSI code where not well processed like those that clear the entire line or move the cursor around.
Still need to support moving the cursor to far left as its conflicting with the coloredPrefix.
https://en.wikipedia.org/wiki/ANSI_escape_code
@kimmobrunfeldt
Copy link
Contributor

kimmobrunfeldt commented Dec 7, 2016

Could you provide an example what is incorrect behaviour and how this fixes it? I might be just too tired but I didn't yet get the problem this PR solves, thanks.

@aecz
Copy link
Contributor Author

aecz commented Dec 12, 2016

Here is some steps to reproduce the issue:

git clone https://github.com/callemall/material-ui-webpack-example.git
cd material-ui-webpack-example
npm i
npm i concurrently
node_modules/.bin/concurrently "npm start"

Comparing the output with "npm start", we can see that many lines are not cleared but added. This is due to manually adding a line break to stdout when we should instead let the process add them.

@aecz aecz mentioned this pull request Jan 9, 2017
@aecz aecz mentioned this pull request Feb 9, 2017
@gustavohenke gustavohenke self-requested a review March 31, 2017 16:36
@gustavohenke gustavohenke merged commit 16260ff into open-cli-tools:master Jul 10, 2017
gustavohenke added a commit that referenced this pull request Jul 11, 2017
@aaronjensen
Copy link

@gustavohenke thanks for merging this, this cleans up the output for us quite a bit. If you get a chance could you please release a new version? We're happy to pull from git from now, but a new version would be great. Thanks! /cc @kimmobrunfeldt

@gustavohenke
Copy link
Member

Sure! I should have done this before. v3.5.1 is on its way! 🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants