Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new kill-others-if-one-fails option (#55) #64

Closed
wants to merge 1 commit into from
Closed

Add new kill-others-if-one-fails option (#55) #64

wants to merge 1 commit into from

Conversation

pawojciechowski
Copy link

No description provided.

gustavohenke
gustavohenke reviewed Feb 2, 2017
View reviewed changes
Copy link
Member

@gustavohenke gustavohenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But what do you think of a shorter flag name? Perhaps --kill-others-on-fail

@gustavohenke gustavohenke mentioned this pull request Feb 21, 2017
Merged
@kentcdodds kentcdodds mentioned this pull request Feb 27, 2017
Merged
@kentcdodds
Copy link
Contributor

I opened up a PR that resolves the conflicts in this PR: #93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gustavohenke gustavohenke gustavohenke left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pawojciechowski @kentcdodds @gustavohenke