cloud_parcel example (+env_state::air_density accessor +making condensation logic accessible by setting -DPMC_USE_SUNDIALS="1" during compilation of PyPartMC) #339

slayoo · 2024-02-13T20:50:49Z

No description provided.

github-actions · 2024-02-13T20:52:26Z

CLANG WARNINGS:

error: no input files [clang-diagnostic-error]
error: no such file or directory: '/github/workspace/files/*.cpp' [clang-diagnostic-error]
error: unable to handle compilation, expected exactly one compiler job in '' [clang-diagnostic-error]

CPPCHECK WARNINGS:

CMakeLists.txt:9:5: error: Unmatched '('. Configuration: ''. [syntaxError]
file(GLOB mods RELATIVE ${CMAKE_SOURCE_DIR} gitmodules/*)
    ^
clang-tidy-report.txt:3:101: error: syntax error [syntaxError]
error: unable to handle compilation, expected exactly one compiler job in '' [clang-diagnostic-error]
                                                                                                    ^

github-actions · 2024-02-14T03:55:47Z

CLANG WARNINGS:

/github/workspace/files/src%2Fpypartmc.cpp:7:10: error: 'pybind11/pybind11.h' file not found [clang-diagnostic-error]
#include "pybind11/pybind11.h"
         ^~~~~~~~~~~~~~~~~~~~~
/github/workspace/files/src%2Fpypartmc.cpp:32:9: warning: function-like macro 'STRINGIFY' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage]
#define STRINGIFY(x) #x
        ^
/github/workspace/files/src%2Fpypartmc.cpp:33:9: warning: function-like macro 'MACRO_STRINGIFY' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage]
#define MACRO_STRINGIFY(x) STRINGIFY(x)
        ^
/github/workspace/files/src%2Fpypartmc.cpp:42:1: warning: use a trailing return type for this function [modernize-use-trailing-return-type]
PYBIND11_MODULE(_PyPartMC, m) {
^
/github/workspace/files/src%2Fpypartmc.cpp:42:26: warning: all parameters should be named in a function [readability-named-parameter]
PYBIND11_MODULE(_PyPartMC, m) {
                         ^
                          /*unused*/  /*unused*/

CPPCHECK WARNINGS:

CMakeLists.txt:9:5: error: Unmatched '('. Configuration: ''. [syntaxError]
file(GLOB mods RELATIVE ${CMAKE_SOURCE_DIR} gitmodules/*)
    ^
clang-tidy-report.txt:14:31: error: Unmatched '{'. Configuration: ''. [syntaxError]
PYBIND11_MODULE(_PyPartMC, m) {
                              ^
src%2Fenv_state.F90:15:40: error: There is an unknown macro here somewhere. Configuration is required. If bind is a macro then please configure it. [unknownMacro]
    subroutine f_env_state_ctor(ptr_c) bind(C)
                                       ^
src%2Fenv_state.hpp:30:5: style: Struct 'EnvState' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
    EnvState(const nlohmann::json &json) :
    ^
nofile:0:0: information: Cppcheck cannot find all the include files (use --check-config for details) [missingInclude]

github-actions · 2024-02-14T15:42:23Z

CLANG WARNINGS:

/github/workspace/files/src%2Fpypartmc.cpp:7:10: error: 'pybind11/pybind11.h' file not found [clang-diagnostic-error]
#include "pybind11/pybind11.h"
         ^~~~~~~~~~~~~~~~~~~~~
/github/workspace/files/src%2Fpypartmc.cpp:32:9: warning: function-like macro 'STRINGIFY' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage]
#define STRINGIFY(x) #x
        ^
/github/workspace/files/src%2Fpypartmc.cpp:33:9: warning: function-like macro 'MACRO_STRINGIFY' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage]
#define MACRO_STRINGIFY(x) STRINGIFY(x)
        ^
/github/workspace/files/src%2Fpypartmc.cpp:42:1: warning: use a trailing return type for this function [modernize-use-trailing-return-type]
PYBIND11_MODULE(_PyPartMC, m) {
^
/github/workspace/files/src%2Fpypartmc.cpp:42:26: warning: all parameters should be named in a function [readability-named-parameter]
PYBIND11_MODULE(_PyPartMC, m) {
                         ^
                          /*unused*/  /*unused*/

CPPCHECK WARNINGS:

CMakeLists.txt:9:5: error: Unmatched '('. Configuration: ''. [syntaxError]
file(GLOB mods RELATIVE ${CMAKE_SOURCE_DIR} gitmodules/*)
    ^
README.md:10:83: error: No pair for character ('). Can't process file. File is either invalid or unicode, which is currently not supported. [syntaxError]
For an outline of the project, rationale, architecture, and features, refer to: [D'Aquino et al., 2023 (arXiv)](https://doi.org/10.48550/arXiv.2308.02052) (please cite if PyPartMC is used in your research).
                                                                                  ^
clang-tidy-report.txt:14:31: error: Unmatched '{'. Configuration: ''. [syntaxError]
PYBIND11_MODULE(_PyPartMC, m) {
                              ^
src%2Fenv_state.F90:15:40: error: There is an unknown macro here somewhere. Configuration is required. If bind is a macro then please configure it. [unknownMacro]
    subroutine f_env_state_ctor(ptr_c) bind(C)
                                       ^
src%2Fenv_state.hpp:30:5: style: Struct 'EnvState' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
    EnvState(const nlohmann::json &json) :
    ^
tests%2Ftest_env_state.py:21:69: error: syntax error [syntaxError]
    @pytest.mark.parametrize("ctor_arg", (ENV_STATE_CTOR_ARG_MINIMAL,))
                                                                    ^
tests%2Ftest_run_part.py:31:5: error: syntax error: keyword 'return' is not allowed in global scope [syntaxError]
    return (
    ^
tests%2Ftest_scenario.py:307:9: error: syntax error [syntaxError]
        if len(data) == 2 and isinstance(data[1], dict) and len(data[1].keys()) == 1:
        ^
nofile:0:0: information: Cppcheck cannot find all the include files (use --check-config for details) [missingInclude]

github-actions · 2024-02-14T15:56:59Z

CLANG WARNINGS:

/github/workspace/files/src%2Fpypartmc.cpp:7:10: error: 'pybind11/pybind11.h' file not found [clang-diagnostic-error]
#include "pybind11/pybind11.h"
         ^~~~~~~~~~~~~~~~~~~~~
/github/workspace/files/src%2Fpypartmc.cpp:32:9: warning: function-like macro 'STRINGIFY' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage]
#define STRINGIFY(x) #x
        ^
/github/workspace/files/src%2Fpypartmc.cpp:33:9: warning: function-like macro 'MACRO_STRINGIFY' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage]
#define MACRO_STRINGIFY(x) STRINGIFY(x)
        ^
/github/workspace/files/src%2Fpypartmc.cpp:42:1: warning: use a trailing return type for this function [modernize-use-trailing-return-type]
PYBIND11_MODULE(_PyPartMC, m) {
^
/github/workspace/files/src%2Fpypartmc.cpp:42:26: warning: all parameters should be named in a function [readability-named-parameter]
PYBIND11_MODULE(_PyPartMC, m) {
                         ^
                          /*unused*/  /*unused*/

CPPCHECK WARNINGS:

CMakeLists.txt:9:5: error: Unmatched '('. Configuration: ''. [syntaxError]
file(GLOB mods RELATIVE ${CMAKE_SOURCE_DIR} gitmodules/*)
    ^
README.md:10:83: error: No pair for character ('). Can't process file. File is either invalid or unicode, which is currently not supported. [syntaxError]
For an outline of the project, rationale, architecture, and features, refer to: [D'Aquino et al., 2023 (arXiv)](https://doi.org/10.48550/arXiv.2308.02052) (please cite if PyPartMC is used in your research).
                                                                                  ^
clang-tidy-report.txt:14:31: error: Unmatched '{'. Configuration: ''. [syntaxError]
PYBIND11_MODULE(_PyPartMC, m) {
                              ^
src%2Fenv_state.F90:15:40: error: There is an unknown macro here somewhere. Configuration is required. If bind is a macro then please configure it. [unknownMacro]
    subroutine f_env_state_ctor(ptr_c) bind(C)
                                       ^
src%2Fenv_state.hpp:30:5: style: Struct 'EnvState' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
    EnvState(const nlohmann::json &json) :
    ^
tests%2Ftest_env_state.py:21:69: error: syntax error [syntaxError]
    @pytest.mark.parametrize("ctor_arg", (ENV_STATE_CTOR_ARG_MINIMAL,))
                                                                    ^
tests%2Ftest_run_part.py:31:5: error: syntax error: keyword 'return' is not allowed in global scope [syntaxError]
    return (
    ^
tests%2Ftest_scenario.py:307:9: error: syntax error [syntaxError]
        if len(data) == 2 and isinstance(data[1], dict) and len(data[1].keys()) == 1:
        ^
nofile:0:0: information: Cppcheck cannot find all the include files (use --check-config for details) [missingInclude]

github-actions · 2024-02-14T16:15:53Z

CLANG WARNINGS:

/github/workspace/files/src%2Fpypartmc.cpp:7:10: error: 'pybind11/pybind11.h' file not found [clang-diagnostic-error]
#include "pybind11/pybind11.h"
         ^~~~~~~~~~~~~~~~~~~~~
/github/workspace/files/src%2Fpypartmc.cpp:32:9: warning: function-like macro 'STRINGIFY' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage]
#define STRINGIFY(x) #x
        ^
/github/workspace/files/src%2Fpypartmc.cpp:33:9: warning: function-like macro 'MACRO_STRINGIFY' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage]
#define MACRO_STRINGIFY(x) STRINGIFY(x)
        ^
/github/workspace/files/src%2Fpypartmc.cpp:42:1: warning: use a trailing return type for this function [modernize-use-trailing-return-type]
PYBIND11_MODULE(_PyPartMC, m) {
^
/github/workspace/files/src%2Fpypartmc.cpp:42:26: warning: all parameters should be named in a function [readability-named-parameter]
PYBIND11_MODULE(_PyPartMC, m) {
                         ^
                          /*unused*/  /*unused*/

CPPCHECK WARNINGS:

CMakeLists.txt:9:5: error: Unmatched '('. Configuration: ''. [syntaxError]
file(GLOB mods RELATIVE ${CMAKE_SOURCE_DIR} gitmodules/*)
    ^
README.md:10:83: error: No pair for character ('). Can't process file. File is either invalid or unicode, which is currently not supported. [syntaxError]
For an outline of the project, rationale, architecture, and features, refer to: [D'Aquino et al., 2023 (arXiv)](https://doi.org/10.48550/arXiv.2308.02052) (please cite if PyPartMC is used in your research).
                                                                                  ^
clang-tidy-report.txt:14:31: error: Unmatched '{'. Configuration: ''. [syntaxError]
PYBIND11_MODULE(_PyPartMC, m) {
                              ^
src%2Fenv_state.F90:15:40: error: There is an unknown macro here somewhere. Configuration is required. If bind is a macro then please configure it. [unknownMacro]
    subroutine f_env_state_ctor(ptr_c) bind(C)
                                       ^
src%2Fenv_state.hpp:30:5: style: Struct 'EnvState' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
    EnvState(const nlohmann::json &json) :
    ^
tests%2Ftest_env_state.py:21:69: error: syntax error [syntaxError]
    @pytest.mark.parametrize("ctor_arg", (ENV_STATE_CTOR_ARG_MINIMAL,))
                                                                    ^
tests%2Ftest_run_part.py:31:5: error: syntax error: keyword 'return' is not allowed in global scope [syntaxError]
    return (
    ^
tests%2Ftest_scenario.py:307:9: error: syntax error [syntaxError]
        if len(data) == 2 and isinstance(data[1], dict) and len(data[1].keys()) == 1:
        ^
nofile:0:0: information: Cppcheck cannot find all the include files (use --check-config for details) [missingInclude]

github-actions · 2024-02-14T16:28:50Z

CLANG WARNINGS:

/github/workspace/files/src%2Fpypartmc.cpp:7:10: error: 'pybind11/pybind11.h' file not found [clang-diagnostic-error]
#include "pybind11/pybind11.h"
         ^~~~~~~~~~~~~~~~~~~~~
/github/workspace/files/src%2Fpypartmc.cpp:32:9: warning: function-like macro 'STRINGIFY' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage]
#define STRINGIFY(x) #x
        ^
/github/workspace/files/src%2Fpypartmc.cpp:33:9: warning: function-like macro 'MACRO_STRINGIFY' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage]
#define MACRO_STRINGIFY(x) STRINGIFY(x)
        ^
/github/workspace/files/src%2Fpypartmc.cpp:42:1: warning: use a trailing return type for this function [modernize-use-trailing-return-type]
PYBIND11_MODULE(_PyPartMC, m) {
^
/github/workspace/files/src%2Fpypartmc.cpp:42:26: warning: all parameters should be named in a function [readability-named-parameter]
PYBIND11_MODULE(_PyPartMC, m) {
                         ^
                          /*unused*/  /*unused*/

CPPCHECK WARNINGS:

CMakeLists.txt:9:5: error: Unmatched '('. Configuration: ''. [syntaxError]
file(GLOB mods RELATIVE ${CMAKE_SOURCE_DIR} gitmodules/*)
    ^
README.md:10:83: error: No pair for character ('). Can't process file. File is either invalid or unicode, which is currently not supported. [syntaxError]
For an outline of the project, rationale, architecture, and features, refer to: [D'Aquino et al., 2023 (arXiv)](https://doi.org/10.48550/arXiv.2308.02052) (please cite if PyPartMC is used in your research).
                                                                                  ^
clang-tidy-report.txt:14:31: error: Unmatched '{'. Configuration: ''. [syntaxError]
PYBIND11_MODULE(_PyPartMC, m) {
                              ^
src%2Fenv_state.F90:15:40: error: There is an unknown macro here somewhere. Configuration is required. If bind is a macro then please configure it. [unknownMacro]
    subroutine f_env_state_ctor(ptr_c) bind(C)
                                       ^
src%2Fenv_state.hpp:30:5: style: Struct 'EnvState' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
    EnvState(const nlohmann::json &json) :
    ^
tests%2Ftest_env_state.py:21:69: error: syntax error [syntaxError]
    @pytest.mark.parametrize("ctor_arg", (ENV_STATE_CTOR_ARG_MINIMAL,))
                                                                    ^
tests%2Ftest_run_part.py:32:5: error: syntax error: keyword 'return' is not allowed in global scope [syntaxError]
    return (
    ^
tests%2Ftest_scenario.py:307:9: error: syntax error [syntaxError]
        if len(data) == 2 and isinstance(data[1], dict) and len(data[1].keys()) == 1:
        ^
nofile:0:0: information: Cppcheck cannot find all the include files (use --check-config for details) [missingInclude]

github-actions · 2024-02-14T17:17:34Z

CLANG WARNINGS:

/github/workspace/files/src%2Fpypartmc.cpp:7:10: error: 'pybind11/pybind11.h' file not found [clang-diagnostic-error]
#include "pybind11/pybind11.h"
         ^~~~~~~~~~~~~~~~~~~~~
/github/workspace/files/src%2Fpypartmc.cpp:32:9: warning: function-like macro 'STRINGIFY' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage]
#define STRINGIFY(x) #x
        ^
/github/workspace/files/src%2Fpypartmc.cpp:33:9: warning: function-like macro 'MACRO_STRINGIFY' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage]
#define MACRO_STRINGIFY(x) STRINGIFY(x)
        ^
/github/workspace/files/src%2Fpypartmc.cpp:42:1: warning: use a trailing return type for this function [modernize-use-trailing-return-type]
PYBIND11_MODULE(_PyPartMC, m) {
^
/github/workspace/files/src%2Fpypartmc.cpp:42:26: warning: all parameters should be named in a function [readability-named-parameter]
PYBIND11_MODULE(_PyPartMC, m) {
                         ^
                          /*unused*/  /*unused*/

CPPCHECK WARNINGS:

CMakeLists.txt:9:5: error: Unmatched '('. Configuration: ''. [syntaxError]
file(GLOB mods RELATIVE ${CMAKE_SOURCE_DIR} gitmodules/*)
    ^
README.md:10:83: error: No pair for character ('). Can't process file. File is either invalid or unicode, which is currently not supported. [syntaxError]
For an outline of the project, rationale, architecture, and features, refer to: [D'Aquino et al., 2023 (arXiv)](https://doi.org/10.48550/arXiv.2308.02052) (please cite if PyPartMC is used in your research).
                                                                                  ^
clang-tidy-report.txt:14:31: error: Unmatched '{'. Configuration: ''. [syntaxError]
PYBIND11_MODULE(_PyPartMC, m) {
                              ^
src%2Fenv_state.F90:15:40: error: There is an unknown macro here somewhere. Configuration is required. If bind is a macro then please configure it. [unknownMacro]
    subroutine f_env_state_ctor(ptr_c) bind(C)
                                       ^
src%2Fenv_state.hpp:30:5: style: Struct 'EnvState' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
    EnvState(const nlohmann::json &json) :
    ^
tests%2Ftest_env_state.py:30:69: error: syntax error [syntaxError]
    @pytest.mark.parametrize("ctor_arg", (ENV_STATE_CTOR_ARG_MINIMAL,))
                                                                    ^
tests%2Ftest_run_part.py:33:5: error: syntax error: keyword 'return' is not allowed in global scope [syntaxError]
    return (
    ^
tests%2Ftest_scenario.py:307:9: error: syntax error [syntaxError]
        if len(data) == 2 and isinstance(data[1], dict) and len(data[1].keys()) == 1:
        ^
nofile:0:0: information: Cppcheck cannot find all the include files (use --check-config for details) [missingInclude]

github-actions · 2024-02-14T17:35:38Z

CLANG WARNINGS:

/github/workspace/files/src%2Fpypartmc.cpp:7:10: error: 'pybind11/pybind11.h' file not found [clang-diagnostic-error]
#include "pybind11/pybind11.h"
         ^~~~~~~~~~~~~~~~~~~~~
/github/workspace/files/src%2Fpypartmc.cpp:32:9: warning: function-like macro 'STRINGIFY' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage]
#define STRINGIFY(x) #x
        ^
/github/workspace/files/src%2Fpypartmc.cpp:33:9: warning: function-like macro 'MACRO_STRINGIFY' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage]
#define MACRO_STRINGIFY(x) STRINGIFY(x)
        ^
/github/workspace/files/src%2Fpypartmc.cpp:42:1: warning: use a trailing return type for this function [modernize-use-trailing-return-type]
PYBIND11_MODULE(_PyPartMC, m) {
^
/github/workspace/files/src%2Fpypartmc.cpp:42:26: warning: all parameters should be named in a function [readability-named-parameter]
PYBIND11_MODULE(_PyPartMC, m) {
                         ^
                          /*unused*/  /*unused*/

CPPCHECK WARNINGS:

CMakeLists.txt:9:5: error: Unmatched '('. Configuration: ''. [syntaxError]
file(GLOB mods RELATIVE ${CMAKE_SOURCE_DIR} gitmodules/*)
    ^
README.md:10:83: error: No pair for character ('). Can't process file. File is either invalid or unicode, which is currently not supported. [syntaxError]
For an outline of the project, rationale, architecture, and features, refer to: [D'Aquino et al., 2023 (arXiv)](https://doi.org/10.48550/arXiv.2308.02052) (please cite if PyPartMC is used in your research).
                                                                                  ^
clang-tidy-report.txt:14:31: error: Unmatched '{'. Configuration: ''. [syntaxError]
PYBIND11_MODULE(_PyPartMC, m) {
                              ^
src%2Fenv_state.F90:15:40: error: There is an unknown macro here somewhere. Configuration is required. If bind is a macro then please configure it. [unknownMacro]
    subroutine f_env_state_ctor(ptr_c) bind(C)
                                       ^
src%2Fenv_state.hpp:30:5: style: Struct 'EnvState' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
    EnvState(const nlohmann::json &json) :
    ^
tests%2Ftest_env_state.py:24:69: error: syntax error [syntaxError]
    @pytest.mark.parametrize("ctor_arg", (ENV_STATE_CTOR_ARG_MINIMAL,))
                                                                    ^
tests%2Ftest_run_part.py:33:5: error: syntax error: keyword 'return' is not allowed in global scope [syntaxError]
    return (
    ^
tests%2Ftest_scenario.py:307:9: error: syntax error [syntaxError]
        if len(data) == 2 and isinstance(data[1], dict) and len(data[1].keys()) == 1:
        ^
nofile:0:0: information: Cppcheck cannot find all the include files (use --check-config for details) [missingInclude]

…ghtly

github-actions · 2024-02-14T20:56:37Z

CLANG WARNINGS:

/github/workspace/files/src%2Fpypartmc.cpp:7:10: error: 'pybind11/pybind11.h' file not found [clang-diagnostic-error]
#include "pybind11/pybind11.h"
         ^~~~~~~~~~~~~~~~~~~~~
/github/workspace/files/src%2Fpypartmc.cpp:32:9: warning: function-like macro 'STRINGIFY' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage]
#define STRINGIFY(x) #x
        ^
/github/workspace/files/src%2Fpypartmc.cpp:33:9: warning: function-like macro 'MACRO_STRINGIFY' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage]
#define MACRO_STRINGIFY(x) STRINGIFY(x)
        ^
/github/workspace/files/src%2Fpypartmc.cpp:42:1: warning: use a trailing return type for this function [modernize-use-trailing-return-type]
PYBIND11_MODULE(_PyPartMC, m) {
^
/github/workspace/files/src%2Fpypartmc.cpp:42:26: warning: all parameters should be named in a function [readability-named-parameter]
PYBIND11_MODULE(_PyPartMC, m) {
                         ^
                          /*unused*/  /*unused*/

CPPCHECK WARNINGS:

CMakeLists.txt:9:5: error: Unmatched '('. Configuration: ''. [syntaxError]
file(GLOB mods RELATIVE ${CMAKE_SOURCE_DIR} gitmodules/*)
    ^
README.md:10:83: error: No pair for character ('). Can't process file. File is either invalid or unicode, which is currently not supported. [syntaxError]
For an outline of the project, rationale, architecture, and features, refer to: [D'Aquino et al., 2023 (arXiv)](https://doi.org/10.48550/arXiv.2308.02052) (please cite if PyPartMC is used in your research).
                                                                                  ^
clang-tidy-report.txt:14:31: error: Unmatched '{'. Configuration: ''. [syntaxError]
PYBIND11_MODULE(_PyPartMC, m) {
                              ^
src%2Fenv_state.F90:15:40: error: There is an unknown macro here somewhere. Configuration is required. If bind is a macro then please configure it. [unknownMacro]
    subroutine f_env_state_ctor(ptr_c) bind(C)
                                       ^
src%2Fenv_state.hpp:30:5: style: Struct 'EnvState' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
    EnvState(const nlohmann::json &json) :
    ^
tests%2Ftest_env_state.py:24:69: error: syntax error [syntaxError]
    @pytest.mark.parametrize("ctor_arg", (ENV_STATE_CTOR_ARG_MINIMAL,))
                                                                    ^
tests%2Ftest_run_part.py:33:5: error: syntax error: keyword 'return' is not allowed in global scope [syntaxError]
    return (
    ^
tests%2Ftest_scenario.py:307:9: error: syntax error [syntaxError]
        if len(data) == 2 and isinstance(data[1], dict) and len(data[1].keys()) == 1:
        ^
nofile:0:0: information: Cppcheck cannot find all the include files (use --check-config for details) [missingInclude]

github-actions · 2024-02-14T21:31:00Z

CLANG WARNINGS:

/github/workspace/files/src%2Fpypartmc.cpp:7:10: error: 'pybind11/pybind11.h' file not found [clang-diagnostic-error]
#include "pybind11/pybind11.h"
         ^~~~~~~~~~~~~~~~~~~~~
/github/workspace/files/src%2Fpypartmc.cpp:32:9: warning: function-like macro 'STRINGIFY' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage]
#define STRINGIFY(x) #x
        ^
/github/workspace/files/src%2Fpypartmc.cpp:33:9: warning: function-like macro 'MACRO_STRINGIFY' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage]
#define MACRO_STRINGIFY(x) STRINGIFY(x)
        ^
/github/workspace/files/src%2Fpypartmc.cpp:42:1: warning: use a trailing return type for this function [modernize-use-trailing-return-type]
PYBIND11_MODULE(_PyPartMC, m) {
^
/github/workspace/files/src%2Fpypartmc.cpp:42:26: warning: all parameters should be named in a function [readability-named-parameter]
PYBIND11_MODULE(_PyPartMC, m) {
                         ^
                          /*unused*/  /*unused*/

CPPCHECK WARNINGS:

CMakeLists.txt:9:5: error: Unmatched '('. Configuration: ''. [syntaxError]
file(GLOB mods RELATIVE ${CMAKE_SOURCE_DIR} gitmodules/*)
    ^
README.md:10:83: error: No pair for character ('). Can't process file. File is either invalid or unicode, which is currently not supported. [syntaxError]
For an outline of the project, rationale, architecture, and features, refer to: [D'Aquino et al., 2023 (arXiv)](https://doi.org/10.48550/arXiv.2308.02052) (please cite if PyPartMC is used in your research).
                                                                                  ^
clang-tidy-report.txt:14:31: error: Unmatched '{'. Configuration: ''. [syntaxError]
PYBIND11_MODULE(_PyPartMC, m) {
                              ^
src%2Fenv_state.F90:15:40: error: There is an unknown macro here somewhere. Configuration is required. If bind is a macro then please configure it. [unknownMacro]
    subroutine f_env_state_ctor(ptr_c) bind(C)
                                       ^
src%2Fenv_state.hpp:30:5: style: Struct 'EnvState' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
    EnvState(const nlohmann::json &json) :
    ^
tests%2Ftest_env_state.py:25:69: error: syntax error [syntaxError]
    @pytest.mark.parametrize("ctor_arg", (ENV_STATE_CTOR_ARG_MINIMAL,))
                                                                    ^
tests%2Ftest_run_part.py:33:5: error: syntax error: keyword 'return' is not allowed in global scope [syntaxError]
    return (
    ^
tests%2Ftest_scenario.py:307:9: error: syntax error [syntaxError]
        if len(data) == 2 and isinstance(data[1], dict) and len(data[1].keys()) == 1:
        ^
nofile:0:0: information: Cppcheck cannot find all the include files (use --check-config for details) [missingInclude]

github-actions · 2024-02-14T21:46:04Z

CLANG WARNINGS:

/github/workspace/files/src%2Fpypartmc.cpp:7:10: error: 'pybind11/pybind11.h' file not found [clang-diagnostic-error]
#include "pybind11/pybind11.h"
         ^~~~~~~~~~~~~~~~~~~~~
/github/workspace/files/src%2Fpypartmc.cpp:32:9: warning: function-like macro 'STRINGIFY' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage]
#define STRINGIFY(x) #x
        ^
/github/workspace/files/src%2Fpypartmc.cpp:33:9: warning: function-like macro 'MACRO_STRINGIFY' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage]
#define MACRO_STRINGIFY(x) STRINGIFY(x)
        ^
/github/workspace/files/src%2Fpypartmc.cpp:42:1: warning: use a trailing return type for this function [modernize-use-trailing-return-type]
PYBIND11_MODULE(_PyPartMC, m) {
^
/github/workspace/files/src%2Fpypartmc.cpp:42:26: warning: all parameters should be named in a function [readability-named-parameter]
PYBIND11_MODULE(_PyPartMC, m) {
                         ^
                          /*unused*/  /*unused*/

CPPCHECK WARNINGS:

CMakeLists.txt:9:5: error: Unmatched '('. Configuration: ''. [syntaxError]
file(GLOB mods RELATIVE ${CMAKE_SOURCE_DIR} gitmodules/*)
    ^
README.md:10:83: error: No pair for character ('). Can't process file. File is either invalid or unicode, which is currently not supported. [syntaxError]
For an outline of the project, rationale, architecture, and features, refer to: [D'Aquino et al., 2023 (arXiv)](https://doi.org/10.48550/arXiv.2308.02052) (please cite if PyPartMC is used in your research).
                                                                                  ^
clang-tidy-report.txt:14:31: error: Unmatched '{'. Configuration: ''. [syntaxError]
PYBIND11_MODULE(_PyPartMC, m) {
                              ^
src%2Fenv_state.F90:15:40: error: There is an unknown macro here somewhere. Configuration is required. If bind is a macro then please configure it. [unknownMacro]
    subroutine f_env_state_ctor(ptr_c) bind(C)
                                       ^
src%2Fenv_state.hpp:30:5: style: Struct 'EnvState' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
    EnvState(const nlohmann::json &json) :
    ^
tests%2Ftest_env_state.py:25:69: error: syntax error [syntaxError]
    @pytest.mark.parametrize("ctor_arg", (ENV_STATE_CTOR_ARG_MINIMAL,))
                                                                    ^
tests%2Ftest_run_part.py:33:5: error: syntax error: keyword 'return' is not allowed in global scope [syntaxError]
    return (
    ^
tests%2Ftest_scenario.py:307:9: error: syntax error [syntaxError]
        if len(data) == 2 and isinstance(data[1], dict) and len(data[1].keys()) == 1:
        ^
nofile:0:0: information: Cppcheck cannot find all the include files (use --check-config for details) [missingInclude]

github-actions · 2024-02-14T21:48:26Z

CLANG WARNINGS:

/github/workspace/files/src%2Fpypartmc.cpp:7:10: error: 'pybind11/pybind11.h' file not found [clang-diagnostic-error]
#include "pybind11/pybind11.h"
         ^~~~~~~~~~~~~~~~~~~~~
/github/workspace/files/src%2Fpypartmc.cpp:32:9: warning: function-like macro 'STRINGIFY' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage]
#define STRINGIFY(x) #x
        ^
/github/workspace/files/src%2Fpypartmc.cpp:33:9: warning: function-like macro 'MACRO_STRINGIFY' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage]
#define MACRO_STRINGIFY(x) STRINGIFY(x)
        ^
/github/workspace/files/src%2Fpypartmc.cpp:42:1: warning: use a trailing return type for this function [modernize-use-trailing-return-type]
PYBIND11_MODULE(_PyPartMC, m) {
^
/github/workspace/files/src%2Fpypartmc.cpp:42:26: warning: all parameters should be named in a function [readability-named-parameter]
PYBIND11_MODULE(_PyPartMC, m) {
                         ^
                          /*unused*/  /*unused*/

CPPCHECK WARNINGS:

CMakeLists.txt:9:5: error: Unmatched '('. Configuration: ''. [syntaxError]
file(GLOB mods RELATIVE ${CMAKE_SOURCE_DIR} gitmodules/*)
    ^
README.md:10:83: error: No pair for character ('). Can't process file. File is either invalid or unicode, which is currently not supported. [syntaxError]
For an outline of the project, rationale, architecture, and features, refer to: [D'Aquino et al., 2023 (arXiv)](https://doi.org/10.48550/arXiv.2308.02052) (please cite if PyPartMC is used in your research).
                                                                                  ^
clang-tidy-report.txt:14:31: error: Unmatched '{'. Configuration: ''. [syntaxError]
PYBIND11_MODULE(_PyPartMC, m) {
                              ^
src%2Fenv_state.F90:15:40: error: There is an unknown macro here somewhere. Configuration is required. If bind is a macro then please configure it. [unknownMacro]
    subroutine f_env_state_ctor(ptr_c) bind(C)
                                       ^
src%2Fenv_state.hpp:30:5: style: Struct 'EnvState' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
    EnvState(const nlohmann::json &json) :
    ^
tests%2Ftest_env_state.py:25:69: error: syntax error [syntaxError]
    @pytest.mark.parametrize("ctor_arg", (ENV_STATE_CTOR_ARG_MINIMAL,))
                                                                    ^
tests%2Ftest_run_part.py:33:5: error: syntax error: keyword 'return' is not allowed in global scope [syntaxError]
    return (
    ^
tests%2Ftest_scenario.py:307:9: error: syntax error [syntaxError]
        if len(data) == 2 and isinstance(data[1], dict) and len(data[1].keys()) == 1:
        ^
nofile:0:0: information: Cppcheck cannot find all the include files (use --check-config for details) [missingInclude]

set -DPMC_USE_SUNDIALS="1" during compilation of PyPartMC

b068c19

jcurtis2 added 2 commits February 13, 2024 21:49

add density of dry air

0805010

add simple cloud parcel notebook

3b61b35

slayoo added 3 commits February 14, 2024 16:39

add cloud parcel notebook to the README

be96365

bump year in copyright of the notebook :)

cee1627

add tests for env_state.air_density and do_condensation

625db3c

add equilibration to the do_condense test

63e960b

go beyond H2O in the do_condensation run_part test

a60bff6

fix condensation test

1c5b940

add assert to condensation test

2dfb99b

slayoo changed the title ~~set -DPMC_USE_SUNDIALS="1" during compilation of PyPartMC~~ cloud_parcel example (+env_state::air_density accessor +making condensation logic accessible by setting -DPMC_USE_SUNDIALS="1" during compilation of PyPartMC) Feb 14, 2024

fix pylint complaint

02773b2

fix missing density in notebook. increase computational particles sli…

e181dfb

…ghtly

slayoo added 4 commits February 14, 2024 22:29

fix alteration of referenced dictionary

fda0f40

remove commented-out code from the notebook

13d2113

clarify the meaning of constants with si. units

26c00bb

simplifying notebook code

23f66c0

shortening notebook lines

a9bf2b1

jcurtis2 approved these changes Feb 14, 2024

View reviewed changes

shortening notebook lines +1

869494a

slayoo merged commit b3995b2 into main Feb 14, 2024
36 checks passed

slayoo deleted the slayoo-patch-5 branch May 29, 2024 15:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cloud_parcel example (+env_state::air_density accessor +making condensation logic accessible by setting -DPMC_USE_SUNDIALS="1" during compilation of PyPartMC) #339

cloud_parcel example (+env_state::air_density accessor +making condensation logic accessible by setting -DPMC_USE_SUNDIALS="1" during compilation of PyPartMC) #339

slayoo commented Feb 13, 2024

github-actions bot commented Feb 13, 2024

github-actions bot commented Feb 14, 2024

github-actions bot commented Feb 14, 2024

github-actions bot commented Feb 14, 2024

github-actions bot commented Feb 14, 2024

github-actions bot commented Feb 14, 2024

github-actions bot commented Feb 14, 2024

github-actions bot commented Feb 14, 2024

github-actions bot commented Feb 14, 2024

github-actions bot commented Feb 14, 2024

github-actions bot commented Feb 14, 2024

github-actions bot commented Feb 14, 2024

cloud_parcel example (+env_state::air_density accessor +making condensation logic accessible by setting -DPMC_USE_SUNDIALS="1" during compilation of PyPartMC) #339

cloud_parcel example (+env_state::air_density accessor +making condensation logic accessible by setting -DPMC_USE_SUNDIALS="1" during compilation of PyPartMC) #339

Conversation

slayoo commented Feb 13, 2024

github-actions bot commented Feb 13, 2024

github-actions bot commented Feb 14, 2024

github-actions bot commented Feb 14, 2024

github-actions bot commented Feb 14, 2024

github-actions bot commented Feb 14, 2024

github-actions bot commented Feb 14, 2024

github-actions bot commented Feb 14, 2024

github-actions bot commented Feb 14, 2024

github-actions bot commented Feb 14, 2024

github-actions bot commented Feb 14, 2024

github-actions bot commented Feb 14, 2024

github-actions bot commented Feb 14, 2024