Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: add links to terraform docs #633

Merged
merged 3 commits into from
Dec 10, 2024
Merged

Conversation

poussa
Copy link
Collaborator

@poussa poussa commented Dec 10, 2024

Description

Add links to terraform modules so they can be linked to OPEA documentation.

Issues

n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)

Dependencies

n/a.

Tests

Manual testing: doc looks okay and link works.

Copy link
Collaborator

@mkbhanda mkbhanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor typo. Please fix.

README.md Outdated
@@ -57,6 +57,12 @@ To deploy GenAIExamples to Kubernetes using helm charts, you need [Helm](https:/

For a detailed version, see [Deploy GenAIExample/GenAIComps using helm charts](https://github.com/opea-project/GenAIInfra/tree/main/helm-charts/README.md)

### Use terraform to deploy on cloud service providers

You can use [Terraform](https://www.terraform.io/) to create infrastructure to run OPEA applications on various cloud service provider (CSP) ennvironments.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can use [Terraform](https://www.terraform.io/) to create infrastructure to run OPEA applications on various cloud service provider (CSP) ennvironments.
You can use [Terraform](https://www.terraform.io/) to create infrastructure to run OPEA applications on various cloud service provider (CSP) environments.

@poussa
Copy link
Collaborator Author

poussa commented Dec 10, 2024

minor typo. Please fix.

fixed

Copy link
Collaborator

@mkbhanda mkbhanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkbhanda mkbhanda merged commit 56674fc into opea-project:main Dec 10, 2024
5 checks passed
mkbhanda pushed a commit that referenced this pull request Dec 11, 2024
* CI: dump all containers' log for chart test (#627)

Signed-off-by: Lianhao Lu <[email protected]>
Signed-off-by: kkrishTa <[email protected]>

* AKS Deployment for OPEA applications

Signed-off-by: kkrishTa <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Signed-off-by: kkrishTa <[email protected]>

* Reverted changes by pre commit hook. Updated readme as per suggestions

Signed-off-by: kkrishTa <[email protected]>

* Adding code spell ignore for Azure Kubernetes Service

Signed-off-by: kkrishTa <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Signed-off-by: kkrishTa <[email protected]>

* Adding code spell ignore for AKS and reverting pre commit changes

Signed-off-by: kkrishTa <[email protected]>

* Updating cluster name to opea as a generic name

Signed-off-by: kkrishTa <[email protected]>

* helm chart: Add service account support (#624)

* helm: Add service account support in common services

1. Add service account creation support, disabled by default.

2. Add support of sharing the same service account by setting
   global.sharedSAName, disabled by default.

Signed-off-by: Lianhao Lu <[email protected]>

* helm: Add service account support in e2e charts

1. Add service account creation support, enabled by default.

2. Add support of sharing the same service account by setting
   global.sharedSAName, enabled by default.

Signed-off-by: Lianhao Lu <[email protected]>

---------

Signed-off-by: Lianhao Lu <[email protected]>
Signed-off-by: kkrishTa <[email protected]>

* README: add links to terraform docs (#633)

* README: add links to terraform docs

Signed-off-by: Sakari Poussa <[email protected]>

* README: fix broken links

Signed-off-by: Sakari Poussa <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Sakari Poussa <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: kkrishTa <[email protected]>

* Adding link to the Azure terraform readme to opea documentation

Signed-off-by: kkrishTa <[email protected]>

* Corrected md file link

Signed-off-by: kkrishTa <[email protected]>

* Updated relative links

Signed-off-by: kkrishTa <[email protected]>

---------

Signed-off-by: Lianhao Lu <[email protected]>
Signed-off-by: kkrishTa <[email protected]>
Signed-off-by: Sakari Poussa <[email protected]>
Co-authored-by: Lianhao Lu <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Sakari Poussa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants