align VLLM micro-service output format with UI #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xiguiw , UI should work. I am curious which UI you are using? Regarding to alignment with vLLM, we currently have another PR that align in/output with OpenAI format. cc: @lkk12014402 @WenjiaoYue |
@Spycsh |
Spycsh
approved these changes
Aug 6, 2024
VLLM misco-service output format align with UI as well as that of LLM micro-service TGI implementation. Signed-off-by: Wang, Xigui <[email protected]>
xiguiw
force-pushed
the
llm-ms-format-align
branch
from
b240f16 to
e412082
Compare
lvliang-intel
approved these changes
Aug 6, 2024
sharanshirodkar7
pushed a commit
to predictionguard/pg-GenAIComps
that referenced
this pull request
Aug 7, 2024
VLLM misco-service output format align with UI as well as that of LLM micro-service TGI implementation. Signed-off-by: Wang, Xigui <[email protected]> Signed-off-by: sharanshirodkar7 <[email protected]>
yogeshmpandey
pushed a commit
to yogeshmpandey/GenAIComps
that referenced
this pull request
Aug 9, 2024
VLLM misco-service output format align with UI as well as that of LLM micro-service TGI implementation. Signed-off-by: Wang, Xigui <[email protected]>
BaoHuiling
pushed a commit
to siddhivelankar23/GenAIComps
that referenced
this pull request
Aug 15, 2024
VLLM misco-service output format align with UI as well as that of LLM micro-service TGI implementation. Signed-off-by: Wang, Xigui <[email protected]> Signed-off-by: BaoHuiling <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VLLM micro-service output format aligns with UI as well as that of LLM micro-service TGI implementation.
Description
The summary of the proposed changes as long as the relevant motivation and context.
Issues
List the issue or RFC link this PR is working on. If there is no such link, please mark it as
n/a.Type of change
List the type of change like below. Please delete options that are not relevant.
Micros service TGI Implementation and VLLM Implementation output format are not aligned.
VLLM output is not supported and displayed on UI.
TGI micro-service output format:
VLLM micro-service output format:
Dependencies
No
Tests
Verified the fix the response can be output at UI.
Without fix, there are No output displayed at UI. The mega service output format are the same as VLLM micro-service output.