-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize name for LLM comps #1162
Conversation
Update all the names for classes and files in llm comps to follow the standard format Related to issue #998 Signed-off-by: Xinyao Wang <[email protected]>
Update all the names for classes and files in llm comps to follow the standard format, related GenAIComps PR opea-project/GenAIComps#1162 Signed-off-by: Xinyao Wang <[email protected]>
Update all the names for classes and files in llm comps to follow the standard format, related GenAIComps PR opea-project/GenAIComps#1162 Signed-off-by: Xinyao Wang <[email protected]>
3c643a3
to
a41e8b0
Compare
Update all the names for classes and files in llm comps to follow the standard format, related GenAIComps PR opea-project/GenAIComps#1162 Signed-off-by: Xinyao Wang <[email protected]>
Update all the names for classes and files in llm comps to follow the standard format, related GenAIComps PR opea-project/GenAIComps#1162 Signed-off-by: Xinyao Wang <[email protected]>
@XinyaoWa Which standard format that is? Neither this PR description, nor files it changes, contains a link to any specific standard, or rules being followed in naming. The result seems rather inconsistent:
PS. IMHO "OpeaDocSum_TGI" / "OpeaDocSum_vLLM" were more reasonable and readable names than the new ones. Earlier suffix matched backend's official name, and was clearly separated from application / use-case prefix. |
Update all the names for classes and files in llm comps to follow the standard format Related to issue opea-project#998 Signed-off-by: Xinyao Wang <[email protected]> Convert Bedrock microservice to follow text-gen structure Signed-off-by: Jonathan Minkin <[email protected]>
Description
Update all the names for classes and files in llm comps to follow the standard format
Issues
#998
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
no
Tests
tests/llm/*.sh