Merge upstream commits #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add: active state to top navigation * clean up styles
This post dives into the process the Gatsby Inkteam followed to discuss and define our core values. It also lists out our core values and talks about how we plan to further embody them as Gatsby Inc continues to grow. closes #7761 <!-- Q. Which branch should I use for my pull request? A. Use `master` branch (probably). Q. Which branch if my change is an update to Gatsby v2? A. Definitely use `master` branch :) Q. Which branch if my change is an update to documentation or gatsbyjs.org? A. Use `master` branch. A Gatsby maintainer will copy your changes over to the `v1` branch for you Q. Which branch if my change is a bug fix for Gatsby v1? A. In this case, you should use the `v1` branch Q. Which branch if I'm still not sure? A. Use `master` branch. Ask in the PR if you're not sure and a Gatsby maintainer will be happy to help :) Note: We will only accept bug fixes for Gatsby v1. New features should be added to Gatsby v2. Learn more about contributing: https://www.gatsbyjs.org/docs/how-to-contribute/ -->
<!-- Q. Which branch should I use for my pull request? A. Use `master` branch (probably). Q. Which branch if my change is an update to Gatsby v2? A. Definitely use `master` branch :) Q. Which branch if my change is an update to documentation or gatsbyjs.org? A. Use `master` branch. A Gatsby maintainer will copy your changes over to the `v1` branch for you Q. Which branch if my change is a bug fix for Gatsby v1? A. In this case, you should use the `v1` branch Q. Which branch if I'm still not sure? A. Use `master` branch. Ask in the PR if you're not sure and a Gatsby maintainer will be happy to help :) Note: We will only accept bug fixes for Gatsby v1. New features should be added to Gatsby v2. Learn more about contributing: https://www.gatsbyjs.org/docs/how-to-contribute/ -->
* Make sure include the path to the js file not css It'd be ideal to prefetch the css files as well but we'll skip that for now as there's generally relatively few css chunks and they'll get loaded when we hover on a link, etc. I'll create an issue about adding support for it. * Just check if it's a .js file directly
This consolidates site- and starter-showcase list view "thumbnail links" via adding a new component `src/views/shared/thumbnail.js`. Also adds a fragment for the thumbnail image itself (before this, starter images were `fluid`, and site showcase images were `fixed`, now we consistently use `fixed`). Fixes the starter showcase list view thumbnail link UI glitch #7978 and hopefully makes things like #7950 a little easier to implement for both site and starter showcase.
…(active nav state)) (#7995) * Use the palette * Backticks * Stop guesstimating presets.bannerHeight… and actually use it. :-) Also allow any amount of (one-line, scrolling overflow) copy in the banner. * use presets.bannerHeight to define the height of the banner component instead of deriving presets.bannerHeight from padding and font-size/line-height * don’t wrap white-space in banner copy and add horizontal overflow scrolling * slightly reduce banner height * Bring back fixed header height, fix its position being off * DRY * Fix left stop of banner mask-image * Refactor main navigation and a bunch of related things * add a couple of constants that should make the header CSS easier to follow * tidy up here and there, add „SocialNavItem“ component * bring back the header search’s icon which got lost somewhere along the way * refine search styles * properly align all header nav items and search input text so that their text sits on the same baseline as the logo wordmark * even out horizontal navItem margins * slightly update navItem hover style * remove all occurences where we substract 1px (e. g.`calc(100vh - ${presets.headerHeight} - 1px`) but really never needed to * fix superfluous whitespace above the header on the homepage
minimze => minimize
We could also introduce community voting as part of featured sites at some point! Like maybe reserve two featured spots for community choice awards? @KyleAMathews
…ebsites (#7969) * [v2][gatsby-plugin-offline] omit pathPrefix, use it through modifyUrlPrefix * omitPath once * pathPrefix navigateFallback * Fix modifyUrlPrefix and navigateFallback Also comment the new omitPrefix function * Remove useless line * Only use pathPrefix is enabled * Remove unreachable code * Fix formatting + remove redundant code * Remove unnecessary checks
* add gatsby-remark-graphviz package to gatsby/www
* Add BEHIND THE SCENES pages
* How APIS/Plugins Are Run
* Node Creation
* Schema Generation
* Building the GqlType
* Building the Input Filters
* Querying with Sift
* Connections
* Page Creation
* Page -> Node Dependencies
* Node Tracking
* Internal Data Bridge
* Queries
* Query Extraction
* Query Execution
* Normal vs StaticQueries
* Data Storage (Redux)*
* Build Caching*
* Terminology
The repo for https://github.com/greglobinski/gatsby-starter-simple-landing is archived and the demo page is offline
Temporarily import this from Gatsbygram's support/index.js using a relative import, until the package is published on NPM
* Added a way to configure remark options. * Updated using-remark example with the config options. * fix linting
At the moment, the link goes to the Github README but just has another link to the v2 website.
Explain how to use `gatsby-dev` for packages exported from `gatsby` directly.
…ll (#7943) * Check if canonical path is 404.html * Fix problematic redirects when removing trailing slashes
* [v2] fix recursiveOmitBy modifying originalValue When calling `recursiveOmitBy(value, ...)`, if `value` was an array this method was actually modifying the original array instead of returning a new one fixes #7970 * [v2] fix: handle arrays in `recursiveOmitBy` * dont mutate example value when removing ___NODE fields for input schema
* Add tests for non existent page routes, check 404 exists * Remove .first call and check pathname
Added a note around possible wrong import of `graphql` from the `graphql` package instead of `gatsby`. I was bitten by this badly and took more than an hour to figure out!
* Replace the stub article for v2 release notes * next.gatsbyjs.org is deprecated * Update v2-release-notes.md
…ary page (#8303) * add a reference to the plugins documentation page on the plugins library page * Update plugins.js
* [www] run prettier on pre-commit re #7964 * [www] add prettierrc
* Update site showcase listing for iammatthias.com Added built-by links, and description. * Fix yaml
* Added prerequesties added node and Git prerequesties * Added "Install Git" section in tutorial added section to install git * Fixed grammer and added rel tag Removed capitalization of "I" to "i" in install. Changed "do not" to "does not". Added rel="noopener noreferrer" tag to the link. * Fixed Grammer fixed grammer issues. * Added new para to link to tutorial Added new Paragraph to link to Tutorial * Slightly clearer language * added rel="noopener noreferrer" * Don't add prerequisites to getting started as we can assume intermediate developers have node + git installed * Run prettier
* Create using-gatsby-image.md Issue #8103: This is for the second task, "using gatsby-image to prevent image bloat". I did my best to make sure the links from the original article were still present. Not sure how to navigate the fact that in the original article, it's specifically Kyle talking, so right now everything's still in first-person. I also cut the last line, which was leading to the next section of the article so wouldn't be relevant here (unless I should have included that next section as well?). Let me know if there's anything you'd like me to change - this is my first-ever contribution to an open source project (currently in a web dev bootcamp), so I'm sorry if I screwed anything up! * Update using-gatsby-image.md Updated with suggested changes! * just added one more link * fixes
Add info on running 'gatsby develop --host=0.0.0.0' to make the development server listen on both local ip and localhost.
…ze class (#8245) * feat: Customize class via className option. * feat: Disable icon options via options: false. * fix: Exclude style in <head> if icon = false. * docs: Update README with options for new features. * fix: Backticks. * refactor: Improve defaults and options. * test: Add tests, update snapshot. * fixup! refactor: Improve defaults and options. * docs: Update example to match test.
`gatsby-image` takes `onError` and `placeholderStyle` props that were missing from the docs.
Note: this may be a controversial change, but I think the integration tests running on _every_ event (merge/pr/etc.) are key to the slow down, and this will help improve that. Longer term, I'd like to figure out #8269
- add three new starters - add links to docs and demos for all starters
* Deploying to S3/Cloudfront doc * updated links * took out reference * Update deploying-to-s3-cloudfront.md
* ci: attempt to speed-up jobs Note: this is a WIP. I'm thinking CircleCI might work better for this, basically we can report back status quickly on unit/integration tests, and then conditionally (i.e. push button) trigger off the e2e tests before we merge a PR. So we get the best of both worlds, relatively quick running builds and then the assurance that we're not breaking things before merge. * ci: attempt to clean up circleci config and hold for e2e tests * ci: trigger another build * ci: attempt to fix config * ci: try, try again * ci: maybe this time, let's see * chore: try to get e2e job to run * ci: fix circle e2e job (in theory) * ci: fix yaml; side note I love yaml * ci: fix indenting.... * ci: add explicit approval job (can't run task in approval) * chore: make script executable * ci: attempt to run integration tests for realsies * ci: run global install prior to script * ci: big change to dry'ing up config and attempting to reuse resources * ci: attempt to fix config * ci: cache node_modules between runs * ci: use sudo; persist node_modules for each task * ci: run e2e tests in parallel (maybe) * ci: quick fix * ci: attempt to trigger a re-buidl * ci: fix workflow * ci: fix requires * ci: make a few changes/fixes * ci: don't run e2e tests on master * ci: fix nesting * ci: fix nesting * ci: only run certain tasks when packages/* change * ci: only run lint if no changes to packages/* * ci: change assert changed script and succeed faster * ci: run assert changed files after checkout * ci: attempt to DRY it up (maybe) * ci: fix config error * ci: add docker image * ci: fix error with node10 browsers * ci: run tests vs 6/8/10 * ci: update test names * ci: just making sure the grep is working * ci: modify changed files script * ci: remove test * ci: use circle working directory for integration test to copy files * ci: add gatsbygram e2e tests * ci: add jobs * ci: "final" changes * ci: use the sha1 commit hash to detect changed files * ci: fix files_count
* Added space to index.js * Update index.js * Format
ooloth
pushed a commit
that referenced
this pull request
Jun 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring this fork up to date before submitting a PR to gatsby.