change default build info in dockerfile's to something more obviously… #4275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR standardizes the default version number across all Dockerfiles by changing it from '0.8-dev' to '0.0.0-dev', making it more explicitly indicate a development build when not overridden by GitHub Actions.
- Changed default
ONYX_VERSIONARG in/web/Dockerfile,/backend/Dockerfile, and/backend/Dockerfile.model_serverto use semantic versioning format '0.0.0-dev' - Version change affects both build-time ARG and runtime ENV variables across all containers
- Maintains consistent version labeling across frontend, backend, and model server containers
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
ahmadassaf
pushed a commit
to BeameryEdge/onyx
that referenced
this pull request
Mar 15, 2025
… source only (onyx-dot-app#4275) Co-authored-by: Richard Kuo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… source only
Description
Fixes DAN-1555.
https://linear.app/danswer/issue/DAN-1555/look-into-version-numbers-being-wrong
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.