Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add paging by default when calling /artefacts #192

Merged
merged 5 commits into from
Feb 15, 2025

Conversation

imadbourouche
Copy link
Member

@imadbourouche imadbourouche commented Feb 13, 2025

The solution is to activate the paging by default in this route
Screenshot from 2025-02-13 19-32-11
Screenshot from 2025-02-13 19-32-25

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.85%. Comparing base (a680ef1) to head (ac06a03).
Report is 16 commits behind head on development.

Additional details and impacted files
@@               Coverage Diff               @@
##           development     #192      +/-   ##
===============================================
+ Coverage        82.44%   82.85%   +0.41%     
===============================================
  Files              103      105       +2     
  Lines             6834     7034     +200     
===============================================
+ Hits              5634     5828     +194     
- Misses            1200     1206       +6     
Flag Coverage Δ
unittests 82.85% <100.00%> (+0.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@syphax-bouazzouni syphax-bouazzouni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code fine for me, need approval of @jonquet if having that route paginated by default is good or not.

@syphax-bouazzouni syphax-bouazzouni merged commit 728ac87 into development Feb 15, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants