Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: hide private artefacts when getting all artefacts #187

Merged
merged 6 commits into from
Feb 17, 2025

Conversation

imadbourouche
Copy link
Member

@imadbourouche imadbourouche commented Jan 31, 2025

What's change

Hide private artefacts (ontologies) by only setting the read_restriction_based_on attribute based on the ontology access

# Access control
read_restriction_based_on ->(artefct) { artefct.ontology }

Screenshots

  • test user for /artefacts and /distributions
    Screenshot from 2025-02-13 16-17-30
    Screenshot from 2025-02-13 16-18-07

  • admin user for /artefacts and /distributions
    Screenshot from 2025-02-13 16-17-25
    Screenshot from 2025-02-13 16-18-15

@imadbourouche imadbourouche self-assigned this Jan 31, 2025
@syphax-bouazzouni syphax-bouazzouni force-pushed the development branch 4 times, most recently from bbd132c to 194fcfb Compare February 5, 2025 12:34
Copy link

@syphax-bouazzouni syphax-bouazzouni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems fine, but tests are red.

@imadbourouche
Copy link
Member Author

imadbourouche commented Feb 14, 2025

Code seems fine, but tests are red.

i will ask @Bilelkihal about this test, it's not working with agraph and virtuoso test_parse_ontology_has_iri_label

@syphax-bouazzouni
Copy link

syphax-bouazzouni commented Feb 15, 2025

Code seems fine, but tests are red.

i will ask @Bilelkihal about this test, it's not working with agraph and virtuoso test_parse_ontology_has_iri_label

If you merge development again to your branch I fixed that one.

@syphax-bouazzouni syphax-bouazzouni removed the request for review from Bilelkihal February 15, 2025 20:28
@syphax-bouazzouni syphax-bouazzouni merged commit 6ec7a72 into development Feb 17, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants