fix #127, delete provisionalClasses on ontology delete

ontoportal-lirmm · Feb 10, 2022 · c72134f · c72134f
1 parent 735ffbb
commit c72134f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/lib/ontologies_linked_data/models/ontology.rb b/lib/ontologies_linked_data/models/ontology.rb
@@ -361,12 +361,7 @@ def delete(*args)
         self.bring(:provisionalClasses)
         unless self.provisionalClasses.nil?
           self.provisionalClasses.each do |p|
-            p.bring(:ontology)
-            p.bring_remaining
-            onts = p.ontology
-            onts.select! {|x| x.id != self.id}
-            p.ontology = onts
-            p.save()
+            p.delete
           end
         end
 

diff --git a/test/models/test_ontology.rb b/test/models/test_ontology.rb
@@ -300,11 +300,16 @@ def test_ontology_delete
     u, of, contact = ontology_objects()
     o1 = ontologies[0]
     o2 = ontologies[1]
-
+    pc = LinkedData::Models::ProvisionalClass.new({label: "Test Provisional Class", creator: u, ontology: o1})
+    pc.save
     n = LinkedData::Models::Note.new({
                                          creator: u,
                                          relatedOntology: [o1]
                                      })
+    assert pc.valid?
+    pc.save
+    assert_equal true, pc.exist?(reload=true)
+
     assert n.valid?
     n.save()
     assert_equal true, n.exist?(reload=true)