Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CI with onnxruntime==1.19.0 #1125

Merged
merged 8 commits into from
Sep 4, 2024
Merged

Update CI with onnxruntime==1.19.0 #1125

merged 8 commits into from
Sep 4, 2024

Conversation

xadupre
Copy link
Collaborator

@xadupre xadupre commented Sep 3, 2024

No description provided.

@xadupre
Update CI with onnxruntime==1.19.0
63ca777 
Signed-off-by: xadupre <[email protected]>
@xadupre
ruff
be13147 
Signed-off-by: xadupre <[email protected]>
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 4, 2024
View reviewed changes
docs/examples/plot_black_op.py

print("numpy:", numpy.__version__)
print("scikit-learn:", sklearn.__version__)
import skl2onnx # noqa
import skl2onnx

Check notice

Code scanning / CodeQL

Module is imported with 'import' and 'import from' Note documentation

Module 'skl2onnx' is imported with both 'import' and 'import from'.
docs/examples/plot_cast_transformer.py

print("numpy:", np.__version__)
print("scikit-learn:", sklearn.__version__)
import skl2onnx # noqa
import skl2onnx

Check notice

Code scanning / CodeQL

Module is imported with 'import' and 'import from' Note documentation

Module 'skl2onnx' is imported with both 'import' and 'import from'.
docs/examples/plot_convert_syntax.py

print("numpy:", numpy.__version__)
print("scikit-learn:", sklearn.__version__)
import skl2onnx # noqa
import skl2onnx

Check notice

Code scanning / CodeQL

Module is imported with 'import' and 'import from' Note documentation

Module 'skl2onnx' is imported with both 'import' and 'import from'.
docs/tutorial/plot_catwoe_transformer.py
@@ -35,7 +36,7 @@
from skl2onnx.algebra.onnx_ops import OnnxCast
from skl2onnx.algebra.onnx_operator import OnnxSubEstimator
from skl2onnx.sklapi import WOETransformer
import skl2onnx.sklapi.register # noqa
import skl2onnx.sklapi.register # noqa: F401

Check notice

Code scanning / CodeQL

Unused import Note documentation

Import of 'skl2onnx' is not used.
docs/tutorial/plot_ngrams.py
@@ -22,7 +22,7 @@
from sklearn.feature_extraction.text import TfidfVectorizer
from skl2onnx import to_onnx
from skl2onnx.sklapi import TraceableTfidfVectorizer
import skl2onnx.sklapi.register # noqa
import skl2onnx.sklapi.register # noqa: F401

Check notice

Code scanning / CodeQL

Unused import Note documentation

Import of 'skl2onnx' is not used.
skl2onnx/common/data_types.py
Comment on lines +4 to +18
from onnxconverter_common.data_types import ( # noqa: F401
DataType,
Int64Type,
FloatType, # noqa
FloatType,
StringType,
TensorType, # noqa
TensorType,
Int64TensorType,
Int32TensorType,
BooleanTensorType, # noqa
BooleanTensorType,
FloatTensorType,
StringTensorType,
DoubleTensorType, # noqa
DoubleTensorType,
DictionaryType,
SequenceType,
) # noqa
)

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'Int64Type' is not used.
Import of 'FloatType' is not used.
Import of 'StringType' is not used.
skl2onnx/common/utils.py Outdated
Comment on lines 8 to 18
from onnxconverter_common.utils import ( # noqa: F401
sklearn_installed,
skl2onnx_installed,
is_numeric_type,
is_string_type,
cast_list,
convert_to_python_value,
convert_to_python_default_value,
convert_to_list,
check_input_and_output_numbers,
)

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'sklearn_installed' is not used.
Import of 'skl2onnx_installed' is not used.
Import of 'is_numeric_type' is not used.
Import of 'is_string_type' is not used.
Import of 'cast_list' is not used.
Import of 'convert_to_python_value' is not used.
Import of 'convert_to_python_default_value' is not used.
Import of 'convert_to_list' is not used.
Import of 'check_input_and_output_numbers' is not used.
Import of 'check_input_and_output_types' is not used.
skl2onnx/convert.py
@@ -11,8 +11,8 @@
from ._parse import parse_sklearn_model

# Invoke the registration of all our converters and shape calculators.
from . import shape_calculators # noqa
from . import operator_converters # noqa
from . import shape_calculators # noqa: F401

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'shape_calculators' is not used.
skl2onnx/convert.py
from . import shape_calculators # noqa
from . import operator_converters # noqa
from . import shape_calculators # noqa: F401
from . import operator_converters # noqa: F401

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'operator_converters' is not used.
tests/test_onnxruntime.py
@@ -7,7 +7,7 @@
from numpy.testing import assert_allclose

try:
import onnx.reference # noqa
import onnx.reference # noqa: F401

Check notice

Code scanning / CodeQL

Unused import Note test

Import of 'onnx' is not used.
@xadupre
black
38d2b5b 
Signed-off-by: xadupre <[email protected]>
@xadupre
fix missing import
f37f2d6 
Signed-off-by: xadupre <[email protected]>
@xadupre
replace warnings.warning
e8870bd 
Signed-off-by: xadupre <[email protected]>
@xadupre
fix fix
5745598 
Signed-off-by: xadupre <[email protected]>
@xadupre
add missing import
cb54a07 
Signed-off-by: xadupre <[email protected]>
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 4, 2024
View reviewed changes
tests/test_custom_transformer_ordwoe.py
from test_utils import TARGET_OPSET, InferenceSessionEx as InferenceSession
import skl2onnx.sklapi.register # noqa: F401

Check notice

Code scanning / CodeQL

Unused import Note test

Import of 'skl2onnx' is not used.
tests/test_sklearn_woe_transformer.py
from skl2onnx import to_onnx
from test_utils import TARGET_OPSET, InferenceSessionEx as InferenceSession
import skl2onnx.sklapi.register # noqa: F401

Check notice

Code scanning / CodeQL

Unused import Note test

Import of 'skl2onnx' is not used.
@xadupre
fix one test
e4bf83a 
Signed-off-by: xadupre <[email protected]>
@xadupre xadupre merged commit 4532ab2 into onnx:main Sep 4, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@xadupre