Sparml converter: support type StringType and StringType() #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xavier Dupre <[email protected]>
xadupre
added a commit
that referenced
this pull request
Oct 2, 2023
* Check if base_score is available and it is a string type convert it to float (#637) Signed-off-by: Donald Tolley <[email protected]> Signed-off-by: Xavier Dupre <[email protected]> Co-authored-by: Donald Tolley <[email protected]> Signed-off-by: James Cao <[email protected]> * signed (#639) Signed-off-by: Xavier Dupre <[email protected]> Signed-off-by: James Cao <[email protected]> * Bump ONNX 1.14.1 in CI pipelines (#644) * verify onnx 1.14.1 rc2 Signed-off-by: jcwchen <[email protected]> * Bump ONNX 1.14.1 Signed-off-by: jcwchen <[email protected]> --------- Signed-off-by: jcwchen <[email protected]> Signed-off-by: James Cao <[email protected]> * fix (dev): Working start to address issue #648. This will help enable saving and reading of models from Spark, a requirement for GBTClassifier tree conversion Signed-off-by: James Cao <[email protected]> * feat: Allow conversions of SparkML models to ONNX using cluster mode Signed-off-by: James Cao <[email protected]> * fix: fix bug that did not fully create temp paths Signed-off-by: James Cao <[email protected]> * fix: reformat style Signed-off-by: James Cao <[email protected]> * fix: Fixed formatting style to pass ruff tests Signed-off-by: James Cao <[email protected]> --------- Signed-off-by: Donald Tolley <[email protected]> Signed-off-by: Xavier Dupre <[email protected]> Signed-off-by: James Cao <[email protected]> Signed-off-by: jcwchen <[email protected]> Co-authored-by: Xavier Dupré <[email protected]> Co-authored-by: Donald Tolley <[email protected]> Co-authored-by: Chun-Wei Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced #638.