Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump outdated deps #119
Bump outdated deps #119
Changes from 26 commits
de47374
016aca2
06f8682
63382da
2d058b1
15b2663
266f6af
a75c4db
1163a7b
14fa086
8efa110
8f9ca9e
10823ed
c1aeb8a
47babf5
d76b5ef
9ceda20
fd60e23
0ab4de3
27d4fc1
cb97b64
cdbf05c
02f3df0
95c53b6
feb8b85
e7933b5
69cec7d
45c2b92
a95aef9
548e49b
a8329ee
efee6c3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Remove Redundant
buildscript
BlockSince the Kotlin Gradle plugin is already specified in the
plugins
block with the updated version, thebuildscript
block containing theclasspath("org.jetbrains.kotlin:kotlin-gradle-plugin:2.0.21")
dependency is redundant. Removing it can simplify your build script.Apply this diff to remove the redundant
buildscript
block:buildscript { repositories { google() mavenCentral() } dependencies { - classpath("org.jetbrains.kotlin:kotlin-gradle-plugin:2.0.21") } }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking into this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lealobanov, sure, please let me know if you have any questions or need further assistance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Integrate New Integration Test Configurations
You've added
intTestImplementation
andintTestRuntimeOnly
configurations extending fromimplementation
andruntimeOnly
. Ensure that these configurations are properly utilized by defining the corresponding source sets and tasks for integration tests. This will enable the project to compile and run integration tests separately from unit tests.Consider adding the following to define the integration test source set and tasks:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Downgraded to 8.8 as 8.9 is not officially supported by Kotlin 2.0 (or versions <2)