-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update examples docs with signature verification #102
Conversation
WalkthroughThe changes introduce a new section titled "Verifying Signatures" in the README files for both the Java and Kotlin examples. This section describes common paradigms for signing messages, including methods for signing arbitrary messages, user messages with public key verification, and flexible verification allowing any public key to validate a message. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
SDK Examples Unit Test Results16 files 16 suites 0s ⏱️ For more details on these failures, see this check. Results for commit bac6417. |
Common Integration Test Results0 files 0 suites 0s ⏱️ Results for commit bac6417. |
Unit Test Results 53 files ±0 53 suites ±0 8s ⏱️ ±0s For more details on these failures, see this check. Results for commit bac6417. ± Comparison against base commit b4df69c. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- java-example/README.md (2 hunks)
- kotlin-example/README.md (2 hunks)
Additional context used
LanguageTool
java-example/README.md
[style] ~121-~121: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ..., respecting the weights of each key. - Signing an arbitrary user message and verifying...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
kotlin-example/README.md
[style] ~121-~121: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ..., respecting the weights of each key. - Signing an arbitrary user message and verifying...(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Markdownlint
kotlin-example/README.md
22-22: Expected: 2; Actual: 4
Unordered list indentation(MD007, ul-indent)
Additional comments not posted (1)
java-example/README.md (1)
22-22
: Table of Contents Updated CorrectlyThe addition of "Verifying Signatures" to the Table of Contents is correctly implemented and links appropriately to the new section.
Description
Update examples docs with recently merged PR for signature verification
For contributor use:
master
branchFiles changed
in the Github PR explorerSummary by CodeRabbit
New Features
Documentation