[v0.37] Port internal fixes #6937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adding backward compatibility for v0.37.25 * Update engine/common/version/version_control.go Co-authored-by: Jan Bernatik <[email protected]> --------- Co-authored-by: Jan Bernatik <[email protected]>
Co-authored-by: Supun Setunga <[email protected]>
fxamacker
approved these changes
Jan 27, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v0.37 #6937 +/- ##
==========================================
- Coverage 41.44% 41.44% -0.01%
==========================================
Files 2036 2036
Lines 181784 181784
==========================================
- Hits 75349 75336 -13
- Misses 100194 100206 +12
- Partials 6241 6242 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
peterargue
approved these changes
Jan 27, 2025
SupunS
approved these changes
Jan 27, 2025
|
One unrelated unit test, |
NotSame checks pointer inequality; the input was not a pointer. This caused a failure once testify was updated to explicitly catch and throw an error in this case.
|
Cherry-picked @jordanschalm's fix: #6779 (comment) |
j1010001
approved these changes
Jan 27, 2025
zhangchiqing
approved these changes
Jan 27, 2025
AlexHentschel
approved these changes
Jan 28, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port https://github.com/onflow/flow-go-internal/compare/v0.37-public...v0.37
Effectively updates to Cadence v1.0.4 and atree v0.9.0