[Flow EVM] fix the issue with the hash calculation of the direct calls #6118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-Peter
reviewed
Jun 18, 2024
m-Peter
reviewed
Jun 18, 2024
m-Peter
approved these changes
Jun 18, 2024
janezpodhostnik
approved these changes
Jun 20, 2024
|
@janezpodhostnik yes, it might also break some older tranasactions, so we might keep it for the testnet :-? |
|
That means that if we merge this, we will have to be careful to exclude it from any upgrades we do to previewnet in the future. |
devbugging
reviewed
Jun 24, 2024
devbugging
approved these changes
Jun 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6118 +/- ##
=======================================
Coverage 41.62% 41.62%
=======================================
Files 1973 1973
Lines 139330 139331 +1
=======================================
+ Hits 57990 57995 +5
+ Misses 75318 75316 -2
+ Partials 6022 6020 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…of github.com:onflow/flow-go into ramtin/6115-fix-potential-hash-issue-for-direct-calls
ramtinms
deleted the
ramtin/6115-fix-potential-hash-issue-for-direct-calls
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #6115
To support the 3rd party tools that are not Flow aware, we compute the hash for the direct calls using Legacy Tx format. Yet we don't have signatures, and the uniqueness of hash values is dependent on the source (From field) and nonce. In this PR we define a canonical format for the legacy tx where we include the source information as part of the signatures (V) and we also define what should be set for R, and S.