Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report storage traversing errors during metrics collection #5997

Merged
merged 1 commit into from
May 30, 2024

Conversation

SupunS
Copy link
Member

@SupunS SupunS commented May 29, 2024

No description provided.

@SupunS SupunS self-assigned this May 29, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 29, 2024

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 55.86%. Comparing base (fd98915) to head (704d425).

Files Patch % Lines
...l/ledger/migrations/migration_metrics_collector.go 50.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5997      +/-   ##
==========================================
+ Coverage   55.84%   55.86%   +0.01%     
==========================================
  Files        1130     1130              
  Lines       89512    89522      +10     
==========================================
+ Hits        49989    50007      +18     
+ Misses      34759    34749      -10     
- Partials     4764     4766       +2     
Flag Coverage Δ
unittests 55.86% <54.54%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SupunS SupunS marked this pull request as ready for review May 29, 2024 22:37
@SupunS SupunS requested review from a team May 29, 2024 22:38
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@turbolent turbolent enabled auto-merge May 29, 2024 22:40
@SupunS SupunS requested a review from a team May 30, 2024 01:12
@turbolent turbolent added this pull request to the merge queue May 30, 2024
Merged via the queue into master with commit b968034 May 30, 2024
55 checks passed
@turbolent turbolent deleted the supun/migration-stats branch May 30, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants