-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Payload.Address() to allow migrations, etc. to reduce overhead #5948
Conversation
This commit adds Payload.Address(). It can be used by programs to reduce overhead of extracting address from payload key.
056cbc8
to
eaac808
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5948 +/- ##
==========================================
+ Coverage 55.78% 55.80% +0.01%
==========================================
Files 1128 1128
Lines 88977 88996 +19
==========================================
+ Hits 49636 49662 +26
+ Misses 34599 34591 -8
- Partials 4742 4743 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This reduces overhead of decoding and creating payload key.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great refactor and improvement! 👏
bd91739
to
53c94b2
Compare
This PR adds
Payload.Address()
to extract and return payload address. This can be used (e.g. by migrations) to reduce overhead of extracting address from payload key.Discussion 🧵 #5942 (comment)