[EVM] Optimize event data #5779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-Peter
reviewed
Apr 25, 2024
added 2 commits
April 25, 2024 18:01
# Conflicts: # fvm/evm/types/events.go
m-Peter
reviewed
Apr 25, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5779 +/- ##
==========================================
+ Coverage 55.67% 55.70% +0.02%
==========================================
Files 1094 1094
Lines 85576 85571 -5
==========================================
+ Hits 47648 47669 +21
+ Misses 33321 33296 -25
+ Partials 4607 4606 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
# Conflicts: # fvm/evm/handler/handler.go
ramtinms
approved these changes
Apr 26, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #5504 #5760 #5628
Change and optimize transaction event data emitted as well as refactor some of the code.
💔 API Breaking Change
There were several breaking changes made in the transaction event fields:
transactionfield renamed topayload(still contains the same data)transactionHashrenamed tohashtransactionTyperenamed totypedeployedContractAddressrenamed tocontractAddressvmErrorrenamed toerrorand now it only contains the error code not the descriptionfailedfield removed (error field can be used to detect failure)indexfield was added, which determines the transaction index in blockOn the block event a new field was added:
totalGasUsedwhich stores a sum of all the gas used by included transactions