unskipping the TestGhostNodeExample tests #1670
Conversation
| @@ -22,7 +22,6 @@ import ( | |||
| // TestGhostNodeExample_Subscribe demonstrates how to emulate a node and receive all inbound events for it | |||
| func TestGhostNodeExample_Subscribe(t *testing.T) { | |||
|
|
|||
| t.Skip() | |||
There was a problem hiding this comment.
testing if the unskipping passes CI.
|
| ) | ||
|
|
||
| nodes := append([]testnet.NodeConfig{collNode, conNode1, conNode2, conNode3, realExeNode, verNode, ghostExeNode}) | ||
| nodes := append([]testnet.NodeConfig{collNode, conNode1, conNode2, conNode3, realExeNode, verNode, ghostExeNode, accessNode}) | ||
| conf := testnet.NewNetworkConfig("ghost_example_subscribe", nodes) | ||
|
|
||
| net := testnet.PrepareFlowNetwork(t, conf) |
There was a problem hiding this comment.
This test needs to call testnet.PrepareFlowNetwork(t, conf) to setup all the docker instances. That call need the *testing.T object and that is not available if I convert this test to an ExampleTest :(
There was a problem hiding this comment.
Ahhh I see :/
Okay, in that case it's okay, can we at least update https://github.com/onflow/flow-go/pull/1670/files#diff-6df27b5bc6af729e3267f2404aa0d5e17319d629fbfffd697f1272474f59cfd2L19-L20 to explain that these tests are actually meaningful tests, and don't solely exist to serve as examples? thanks :)
| ) | ||
|
|
||
| nodes := append([]testnet.NodeConfig{collNode, conNode1, conNode2, conNode3, realExeNode, verNode, ghostExeNode}) | ||
| nodes := append([]testnet.NodeConfig{collNode, conNode1, conNode2, conNode3, realExeNode, verNode, ghostExeNode, accessNode}) | ||
| conf := testnet.NewNetworkConfig("ghost_example_subscribe", nodes) | ||
|
|
||
| net := testnet.PrepareFlowNetwork(t, conf) |
There was a problem hiding this comment.
Ahhh I see :/
Okay, in that case it's okay, can we at least update https://github.com/onflow/flow-go/pull/1670/files#diff-6df27b5bc6af729e3267f2404aa0d5e17319d629fbfffd697f1272474f59cfd2L19-L20 to explain that these tests are actually meaningful tests, and don't solely exist to serve as examples? thanks :)
Codecov Report
@@ Coverage Diff @@
## master #1670 +/- ##
==========================================
+ Coverage 56.30% 56.34% +0.03%
==========================================
Files 554 554
Lines 32751 32751
==========================================
+ Hits 18440 18452 +12
+ Misses 11860 11847 -13
- Partials 2451 2452 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
No description provided.