Skip to content

Commit

Permalink
Merge pull request #6839 from onflow/petera/split-access-cohort3-inte…
Browse files Browse the repository at this point in the history
…gration-tests

[CI] Split access cohort3 tests into 2 groups
  • Loading branch information
peterargue authored Jan 1, 2025
2 parents 219660a + 3953304 commit a7656ea
Show file tree
Hide file tree
Showing 10 changed files with 16 additions and 9 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -336,6 +336,9 @@ jobs:
- name: Access Cohort3 Integration Tests
make: make -C integration access-cohort3-tests
runner: ubuntu-latest
- name: Access Cohort4 Integration Tests
make: make -C integration access-cohort4-tests
runner: ubuntu-latest
# test suite has single test which is flaky and needs to be fixed - reminder here to put it back when it's fixed
# - name: BFT (Framework) Integration Tests
# make: make -C integration bft-framework-tests
Expand Down
6 changes: 5 additions & 1 deletion integration/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ test:
CGO_CFLAGS=$(CRYPTO_FLAG) go test $(if $(VERBOSE),-v,) -coverprofile=$(COVER_PROFILE) $(RACE_FLAG) $(if $(JSON_OUTPUT),-json,) $(if $(NUM_RUNS),-count $(NUM_RUNS),) $(GO_TEST_PACKAGES)

.PHONY: access-tests
access-tests: access-cohort1-tests access-cohort2-tests access-cohort3-tests
access-tests: access-cohort1-tests access-cohort2-tests access-cohort3-tests access-cohort4-tests

.PHONY: access-cohort1-tests
access-cohort1-tests:
Expand All @@ -37,6 +37,10 @@ access-cohort2-tests:
access-cohort3-tests:
CGO_CFLAGS=$(CRYPTO_FLAG) go test -failfast $(if $(VERBOSE),-v,) $(RACE_FLAG) $(if $(JSON_OUTPUT),-json,) $(if $(NUM_RUNS),-count $(NUM_RUNS),) ./tests/access/cohort3/...

.PHONY: access-cohort4-tests
access-cohort4-tests:
CGO_CFLAGS=$(CRYPTO_FLAG) go test -failfast $(if $(VERBOSE),-v,) $(RACE_FLAG) $(if $(JSON_OUTPUT),-json,) $(if $(NUM_RUNS),-count $(NUM_RUNS),) ./tests/access/cohort4/...

.PHONY: collection-tests
collection-tests:
CGO_CFLAGS=$(CRYPTO_FLAG) go test -failfast $(if $(VERBOSE),-v,) $(RACE_FLAG) $(if $(JSON_OUTPUT),-json,) $(if $(NUM_RUNS),-count $(NUM_RUNS),) ./tests/collection/...
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ func (s *AccessCircuitBreakerSuite) TestCircuitBreaker() {
// Try to send the transaction for the second time. It should wait less than a second because the circuit breaker
// is configured to break after the first failure
err = accessClient.SendTransaction(s.ctx, signedTx)
//Here we catch the codes.Unknown error, as this is the one that comes from the Circuit Breaker when the state is Open.
// Here we catch the codes.Unknown error, as this is the one that comes from the Circuit Breaker when the state is Open.
assert.Equal(s.T(), codes.Unknown, status.Code(err))

// Reconnect the collection node
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package cohort3
package cohort4

import (
"context"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package cohort3
package cohort4

import (
"context"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package cohort3
package cohort4

import (
"context"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package cohort3
package cohort4

import (
"context"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package cohort3
package cohort4

import (
"bytes"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package cohort3
package cohort4

import (
"context"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package cohort3
package cohort4

import (
"context"
Expand Down

0 comments on commit a7656ea

Please sign in to comment.