Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key rotation mechanism #76

Merged
merged 38 commits into from
Feb 27, 2024
Merged

Key rotation mechanism #76

merged 38 commits into from
Feb 27, 2024

Conversation

devbugging
Copy link
Contributor

@devbugging devbugging commented Feb 23, 2024

Closes: #61

Implementing key-rotation mechanism that takes a file of keys and then rotates the keys upon each signature in a concurrent safe manner.


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@m-Peter m-Peter self-requested a review February 23, 2024 18:08
Copy link
Collaborator

@m-Peter m-Peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job getting this done so quickly 👏

@devbugging devbugging self-assigned this Feb 26, 2024
@devbugging devbugging marked this pull request as ready for review February 26, 2024 17:42
@devbugging devbugging mentioned this pull request Feb 27, 2024
Merged
@devbugging devbugging changed the base branch from gregor/index/previewnet-testing-fixes to main February 27, 2024 14:36
@devbugging devbugging changed the base branch from main to gregor/dev February 27, 2024 14:37
@devbugging devbugging merged commit 84becff into gregor/dev Feb 27, 2024
@m-Peter m-Peter deleted the gregor/index/key-rotation branch March 8, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants