Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bash script to use canarynet instead of canary #73

Merged

Conversation

m-Peter
Copy link
Collaborator

@m-Peter m-Peter commented Feb 22, 2024

Description

The CLI flag condition (https://github.com/onflow/flow-evm-gateway/blob/main/cmd/server/main.go#L60-L62) checks against a value of canarynet instead of canary.


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@m-Peter m-Peter added this to the Flow-EVM-M2 milestone Feb 22, 2024
@m-Peter m-Peter requested a review from nialexsan February 22, 2024 11:32
@m-Peter m-Peter self-assigned this Feb 22, 2024
@m-Peter
Copy link
Collaborator Author

m-Peter commented Feb 22, 2024

Alternatively, I can also update the CLI flag condition. Depends on whether we want to use canary or canarynet.

@franklywatson franklywatson merged commit 2cd75cf into onflow:main Feb 22, 2024
1 check passed
@m-Peter m-Peter deleted the update-bash-script-to-use-canarynet branch February 22, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants