-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General improvements and fixes found during testing #72
General improvements and fixes found during testing #72
Conversation
…fixes' into gregor/index/previewnet-testing-fixes
} | ||
|
||
highestIndex := len(block.TransactionHashes) - 1 | ||
if index > hexutil.Uint(highestIndex) { | ||
return nil | ||
return nil, nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we should return some kind of error here, instead of both values being nil, nil
.
} | ||
|
||
// todo workaround until new version of flow-go is released |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one 👍 I think the evm.TransactionExecuted
event payload is going to contain BlockHash
, so we can avoid the extra DB call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice 👏
Left only a few comments for discussion.
f358376
into
gregor/index/track-flow-heights
This PR includes multiple improvements for issues found during testing, some are: