-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove --evm-enabled
flag in README.md instructions
#568
Conversation
WalkthroughThe changes involve an update to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range and nitpick comments (1)
README.md (1)
45-47
: Approve the removal of--evm-enabled
flag and suggest minor improvementsThe removal of the
--evm-enabled
flag from the Flow Emulator command is correct and aligns with the PR objective. This simplifies the instructions for users.However, there are two minor improvements we can make:
- Add a comma after "locally" on line 45 for better readability.
- Specify the language for the fenced code block on line 47.
Here's the suggested change:
-To run the gateway locally you need to start the Flow Emulator: -``` +To run the gateway locally, you need to start the Flow Emulator: +```bash flow emulator<details> <summary>Tools</summary> <details> <summary>LanguageTool</summary><blockquote> [uncategorized] ~45-~45: Possible missing comma found. Context: ... **Start Emulator** To run the gateway locally you need to start the Flow Emulator: ``... (AI_HYDRA_LEO_MISSING_COMMA) </blockquote></details> <details> <summary>Markdownlint</summary><blockquote> 46-46: null Fenced code blocks should have a language specified (MD040, fenced-code-language) </blockquote></details> </details> </blockquote></details> </blockquote></details> <details> <summary>Review details</summary> **Configuration used: CodeRabbit UI** **Review profile: CHILL** <details> <summary>Commits</summary> Files that changed from the base of the PR and between d57cf9ffa126de1c551fe074afc2b6fdd20ef263 and 8af6a2f5aab56f9b120c4afc9fd1164afd3cba12. </details> <details> <summary>Files selected for processing (1)</summary> * README.md (1 hunks) </details> <details> <summary>Additional context used</summary> <details> <summary>LanguageTool</summary><blockquote> <details> <summary>README.md</summary><blockquote> [uncategorized] ~45-~45: Possible missing comma found. Context: ... **Start Emulator** To run the gateway locally you need to start the Flow Emulator: ``... (AI_HYDRA_LEO_MISSING_COMMA) </blockquote></details> </blockquote></details> <details> <summary>Markdownlint</summary><blockquote> <details> <summary>README.md</summary><blockquote> 46-46: null Fenced code blocks should have a language specified (MD040, fenced-code-language) </blockquote></details> </blockquote></details> </details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch 🙏
Description
The
--evm-enabled
flag has been removed from the flow emulatorFor contributor use:
master
branchFiles changed
in the Github PR explorerSummary by CodeRabbit