fix bug with precision loss for api_request_duration metric

[illia-malachyn]

Closes #441

Summary by CodeRabbit

• Improvements
  • Enhanced precision of request duration measurements for better performance tracking.

[coderabbitai]

Walkthrough

The recent changes enhance the precision of duration measurements in the MeasureRequestDuration method of the DefaultCollector class. By switching from float64(time.Since(start)) to time.Since(start).Seconds(), the adjustments refine how request durations are observed, ensuring a more accurate representation. This modification addresses issues with histogram metrics accuracy while maintaining existing control flow.

Changes

Files	Change Summary
metrics/collector.go	Modified MeasureRequestDuration to improve precision by using time.Since(start).Seconds() instead of float64(time.Since(start)).

Assessment against linked issues

Objective	Addressed	Explanation
Metric floating point values should be emitted verbatim without rounding (#441)	✅
Metric values correspond to the correct bucket they belong to (#441)	❌	The current change does not address bucket allocation.

🐇 In the meadow where data flows,
A change made the timing glow,
No more rounding to bring us woes,
Metrics now dance, precise as they pose.
Hooray for the seconds, so clear, so bright,
Collecting our metrics, all day and night! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[illia-malachyn]

@franklywatson

I tested it locally, it was silly of me to do that conversion.

I'm leaving default buckets for now as their values look fine to me (5ms-10s range). We may adjust them when we have more info on how long our endpoints respond to a user

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 0a40149 and 84ea1ff.

Files selected for processing (1)

• metrics/collector.go (1 hunks)

Additional comments not posted (1)

metrics/collector.go (1)

123-123: Improved precision in duration measurement.

The change from float64(time.Since(start)) to time.Since(start).Seconds() enhances the precision of the duration measurement by directly converting the duration to seconds. This is a more accurate and semantically appropriate representation for time intervals in metrics, addressing the precision loss issue mentioned in the PR objectives.