Populate LogsBloom field with its default fault for block responses

[m-Peter]

Closes: #372
Related: #371

Description

One such example is the genesis block, which does not have any transactions, but even so, the LogsBloom field should be the 256-byte empty bloom, instead of 0x. This breaks the serialization for many tools.

---

For contributor use:

• Targeted PR against master branch
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Code follows the standards mentioned here.
• Updated relevant documentation
• Re-reviewed Files changed in the Github PR explorer
• Added appropriate labels

Summary by CodeRabbit

• New Features

  • Added a LogsBloom field to the blockchain response structure for future logging capabilities.

• Tests

  • Introduced a test case to verify functionality for retrieving the genesis block from the Ethereum blockchain, ensuring expected properties and values.

[coderabbitai]

Walkthrough

This update enhances the BlockChainAPI by adding a LogsBloom field to the block response structure, ensuring it is populated even for blocks without transactions. Additionally, a new test case is introduced to validate the retrieval of the genesis block, confirming its properties and structure. This prepares the code for future logging integration while preserving the functionality of existing features.

Changes

Files	Change Summary
api/api.go	Added LogsBloom field in prepareBlockResponse method to ensure it returns an empty bloom for blocks without transactions.
tests/web3js/eth_non_interactive_test.js	Introduced a test for retrieving the genesis block, checking various properties for correctness and expected behavior.

Assessment against linked issues

Objective	Addressed	Explanation
Populate the LogsBloom field, even for blocks without any transactions (#372)	✅

🐰 In the blockchain's heart, a bloom now shines,
Even when transactions are absent, it aligns.
With tests that ensure the genesis is right,
Our code hops forward, a marvelous sight!
So let’s cheer for the logs and their future delight! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 1ee807f and 80fdaba.

Files selected for processing (2)

• api/api.go (1 hunks)
• tests/web3js/eth_non_interactive_test.js (1 hunks)

Additional comments not posted (2)

tests/web3js/eth_non_interactive_test.js (1)

46-57: LGTM! Ensure consistency in timestamp checks.

The new test case for retrieving the earliest/genesis block is well-structured and covers essential properties, including the logsBloom field. Ensure that the timestamp check is consistent with other tests.

api/api.go (1)

731-731: LGTM! Ensure proper initialization of LogsBloom.

The addition of the LogsBloom field enhances the response structure by providing a placeholder for logs associated with the block. Ensure that the initialization is consistent with other parts of the codebase.