Get storage at API #363

devbugging · 2024-07-17T14:29:20Z

Relies on: #362
Related: #351

This builds on top of #362 and exposes the eth_getStorageAt API needed for inspecting the account storage.

Example:

curl -XPOST 'localhost:3000' --header 'Content-Type: application/json' --data-raw '{"jsonrpc":"2.0", "method": "eth_getStorageAt", "params": ["0x07C2006580b42cB35Bc4583fEB4904626CcdfA60", "0x0", "latest"], "id": 1}'

{"jsonrpc":"2.0","id":1,"result":"0x0000000000000000000000000000000000000000000000000000000000000064"}

For contributor use:

Targeted PR against master branch
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the standards mentioned here.
Updated relevant documentation
Re-reviewed Files changed in the Github PR explorer
Added appropriate labels

coderabbitai · 2024-07-17T14:29:29Z

Warning

Rate limit exceeded

@sideninja has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 19 minutes and 3 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 0880eaa and dd16b2f.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

# Conflicts: # services/requester/remote_state_test.go

m-Peter · 2024-07-18T12:38:59Z

api/api.go

+	address common.Address,
+	storageSlot string,
+	blockNumberOrHash *rpc.BlockNumberOrHash,
+) (hexutil.Bytes, error) {


Let's add some rate-limit functionality on this endpoint as well:

if err := rateLimit(ctx, b.limiter, b.logger); err != nil { return nil, err }

yep good idea

m-Peter · 2024-07-18T12:46:58Z

services/requester/requester.go

+		return nil, err
+	}
+
+	ledger, err := newRemoteLedger(e.config.RPCHost, height)


If the given evmHeight is part of a spork, maybe we should address that? Not necessarily now, but in a follow-up PR.

what do you mean part of a spork?

I mean if it is not in the current spork.

the AN should handle that

services/requester/requester.go

m-Peter · 2024-07-18T12:54:59Z

services/requester/requester.go

+		}
+		cadenceHeight = h.Height
+	}
+
 	stateDB, err := e.stateAt(evmHeight)


I believe here we want:

stateDB, err := e.stateAt(cadenceHeight)

nice catch, I should move this

…to gregor/remote-ledger-storage

m-Peter

Awesome 🎉

devbugging added 4 commits July 17, 2024 14:57

add storage at

3450077

move remote state

0cf8317

add get storage at to interface

eef81ef

get storage at api added

744fc07

devbugging requested review from peterargue and m-Peter as code owners July 17, 2024 14:29

devbugging changed the title ~~Gregor/remote ledger storage~~ Remote ledger storage Jul 17, 2024

devbugging changed the title ~~Remote ledger storage~~ Get storage at API Jul 17, 2024

Merge branch 'gregor/remote-ledger' into gregor/remote-ledger-storage

3871e4f

# Conflicts: # services/requester/remote_state_test.go

m-Peter reviewed Jul 18, 2024

View reviewed changes

services/requester/requester.go Show resolved Hide resolved

devbugging added 2 commits July 18, 2024 14:52

handle latest height value

7314eb2

rate limit api

60ca065

devbugging requested a review from m-Peter July 18, 2024 12:53

devbugging added 3 commits July 18, 2024 14:53

remove log

3d97005

add comment

1b01bd0

Merge branch 'main' into gregor/remote-ledger-storage

999ac8b

m-Peter reviewed Jul 18, 2024

View reviewed changes

devbugging added 3 commits July 18, 2024 14:57

refactor

aee6d67

Merge remote-tracking branch 'origin/gregor/remote-ledger-storage' in…

620ba45

…to gregor/remote-ledger-storage

Merge branch 'main' into gregor/remote-ledger-storage

dd16b2f

devbugging requested a review from m-Peter July 18, 2024 13:11

m-Peter approved these changes Jul 18, 2024

View reviewed changes

devbugging merged commit e648106 into main Jul 18, 2024
2 checks passed

m-Peter deleted the gregor/remote-ledger-storage branch July 18, 2024 16:03

This was referenced Jul 19, 2024

Implement the eth_getStorageAt JSON-RPC endpoint #337

Closed

[Flow EVM] Implement the EVMAddress.storageAt() method onflow/flow-go#6179

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Get storage at API #363

Get storage at API #363

devbugging commented Jul 17, 2024 •

edited

Loading

coderabbitai bot commented Jul 17, 2024 •

edited

Loading

Rate limit exceeded

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

m-Peter Jul 18, 2024

devbugging Jul 18, 2024

m-Peter Jul 18, 2024

devbugging Jul 18, 2024

m-Peter Jul 18, 2024

devbugging Jul 18, 2024

m-Peter Jul 18, 2024

devbugging Jul 18, 2024

m-Peter left a comment

Get storage at API #363

Get storage at API #363

Conversation

devbugging commented Jul 17, 2024 • edited Loading

coderabbitai bot commented Jul 17, 2024 • edited Loading

Rate limit exceeded

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

m-Peter left a comment

Choose a reason for hiding this comment

devbugging commented Jul 17, 2024 •

edited

Loading

coderabbitai bot commented Jul 17, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)