Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add force set height flag #232

Merged
merged 1 commit into from
May 7, 2024
Merged

Add force set height flag #232

merged 1 commit into from
May 7, 2024

Conversation

devbugging
Copy link
Contributor

@devbugging devbugging commented May 7, 2024

Description

This flag can force set the starting height even if the database contains existing indexed blocks.


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

Summary by CodeRabbit

  • New Features

    • Added a configuration option to manually set the starting Cadence height, enhancing control over operational parameters.
  • Bug Fixes

    • Implemented a warning system for cases where the starting Cadence height is set manually, ensuring users are aware of the implications.

@devbugging devbugging self-assigned this May 7, 2024
Copy link
Contributor

coderabbitai bot commented May 7, 2024

Walkthrough

This update introduces a new configuration option ForceStartCadenceHeight in the Config struct to manage the starting Cadence height conditionally. The bootstrap.go file now includes a conditional block to check and apply this configuration, issuing a warning if the condition is met. This allows for more flexible control of the starting process based on the configuration.

Changes

File Path Change Summary
bootstrap/bootstrap.go Added conditional block for ForceStartCadenceHeight.
config/config.go Added ForceStartCadenceHeight field and related variable.

🐇✨
In the land of code, where logic threads tight,
A rabbit hopped in, with a change in sight.
With a flick of its ear, and a twinkle in its eye,
Set the Cadence high, oh so high!
"Hop and code," it squeaked with glee,
"For flexible starts, as flexible as can be!" 🌟
🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 8fa4dbc and 05f9341.
Files selected for processing (2)
  • bootstrap/bootstrap.go (1 hunks)
  • config/config.go (3 hunks)
Additional comments not posted (2)
config/config.go (2)

68-69: The addition of ForceStartCadenceHeight to the Config struct is clear and well-documented.


Line range hint 76-95: The handling of the force-start-height flag in the FromFlags function is correctly implemented.

Also applies to: 187-189

@devbugging devbugging requested a review from chasefleming May 7, 2024 20:20
Copy link
Member

@chasefleming chasefleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would remove !!! and maybe add an emoji warning symbol but approved

@devbugging devbugging merged commit ff040b3 into main May 7, 2024
2 checks passed
@m-Peter m-Peter deleted the gregor/force-skip branch July 29, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants